search

ethcatherders / EIPIP

EIP Improvement Process
81 stars 37 forks source link

EIP Editing Office Hour Meeting 26 #277

Closed poojaranjan closed 11 months ago

poojaranjan commented 1 year ago

Date & Time

Tuesday, October 31, 2023, at 15:00 UTC

Location

Zoom: TBA on EthCatHerders Discord #eip-editors Recording: https://www.youtube.com/playlist?list=PL4cwHXAawZxqnDHxOyuwMpyt5s8F8gdmO

Agenda

To Final

To Last Call

To Review

To Withdrawan

TBA

Misc PR

To Draft

Requested in comments

Added from the past meetings TBA

From Satgnant

TBA

Old links

Other details

(Add your Pull Request number to be added to the agenda.)

OniReimu commented 1 year ago

Hi @poojaranjan , could you please include ethereum/EIPs#7632, thanks.

HelloRickey commented 1 year ago

Hi @poojaranjan please take a look at https://github.com/ethereum/EIPs/pull/7651 thanks

d4mr commented 1 year ago

Hi @poojaranjan can https://github.com/ethereum/EIPs/pull/7719 be included as well please, thanks

bafu commented 1 year ago

Hi Pooja, I would like to discuss https://github.com/ethereum/EIPs/pull/7682 (EIP-7517) and move it to Draft. Thank you!

bafu commented 1 year ago

Hi Pooja, I would like to discuss https://github.com/ethereum/EIPs/pull/7804 (EIP-7053) and move it to Final. Thank you!

poojaranjan commented 1 year ago

In the absence of the EIP editor, we're skipping this week. Hopefully, PRs will be merged async in the meantime. If not, it will be reviewed at the next meeting.

Edoumou commented 12 months ago

Hi Pooja, I would like to discuss ethereum/EIPs#7667 (ERC-7092) and move it to Review. Thank you.

kopy-kat commented 12 months ago

Hi Pooja, I would like to discuss https://github.com/ethereum/EIPs/pull/7484 and merge the first draft. Thank you!

strumswell commented 11 months ago

Review of https://github.com/ethereum/EIPs/pull/7547 would be appreciated.

poojaranjan commented 11 months ago

In the absence of the EIP editor, we're skipping this week. Hopefully, PRs will be merged async in the meantime. If not, it will be reviewed at the next meeting on October 31, 2023.

ryanio commented 11 months ago

Hi Pooja 👋 I would like to discuss adding these EIPs (sync or async is fine!): Add EIP: NFT Dynamic Traits #7500 Add EIP: NFT Redeemables #7501 (uses Dynamic Traits)

Have had an initial review/approval from @g11tech but need ✅ from @SamWilsn since he is still in "Requested Changes" state for the EIP numbers update (which has been done).

poojaranjan commented 11 months ago

@ryanio I have added it to the agenda. However, I see the requested changes by two different reviewers. I recommend reaching both of them on EthCatHerders Discord #eip-editors channel.

tbergmueller commented 11 months ago

Hi @poojaranjan ,

we'd like to move ERC-6956 to review and discuss any open poins in the upcoming meeting, in case not approved before. https://github.com/ethereum/EIPs/pull/7903

Side-note, small typo in your ticket description, From Satgnant ;)

dhl commented 11 months ago

Hi @poojaranjan,

My team have requested for ERC-6596 to be moved to review state, and would like to bring this up for discussion during the office hour if the changes have not been merged by then. Would you mind including this on the agenda please?

Edoumou commented 11 months ago

Hello @poojaranjan,

I was wondering if one should reference the new PR after moving ERCs to a separated directory. If so, then I would like to discuss https://github.com/ethereum/ERCs/pull/19 (ERC-7092) and move it to Review. Thank you.

strumswell commented 11 months ago

Same for me https://github.com/ethereum/ERCs/pull/21

tbergmueller commented 11 months ago

Same for me; Instead of https://github.com/ethereum/EIPs/pull/7903 please use https://github.com/ethereum/ERCs/pull/43

Note that for all PRs at the moment pipelines in the ERCs repo fail, mostly due to spelling mistakes and broken links in other ERCs. These are known issues and being actively worked on I believe

Joeysantoro commented 11 months ago

Can we add: https://github.com/ethereum/ERCs/pull/78 to move ERC-7535 to Review and https://github.com/ethereum/ERCs/pull/57 to fix a typo on final ERC-2612?

poojaranjan commented 11 months ago

@Joeysantoro https://github.com/ethereum/ERCs/pull/78 has been added to this meeting. However ERC-2612 is in Final status, it is added to the EIPIP meeting.

bafu commented 11 months ago

Hi Pooja, I would like to discuss https://github.com/ethereum/EIPs/pull/7682 (EIP-7517) and move it to Draft. Thank you!

dhl commented 11 months ago

Hi @poojaranjan! The invite link to discord doesn't work. Would you mind sharing the link?

poojaranjan commented 11 months ago

@dhl ECH Discord

poojaranjan commented 11 months ago

Pull requests that couldn't be discussed today are added to the next meeting. But we hope for them to be merged before the next EIP Editing Office Hour.

poojaranjan commented 11 months ago

Closed in favor of #290