search

ethcatherders / EIPIP

EIP Improvement Process
81 stars 37 forks source link

Call for Input: Accidental function in ERC-223 #283

Closed SamWilsn closed 10 months ago

SamWilsn commented 11 months ago
Decision Will we merge https://github.com/ethereum/EIPs/pull/7856? See that pull request for details.
Method Rough Consensus
Deadline November 16, 2023

tl;dr function was removed from spec then later accidentally re-added.

SamWilsn commented 11 months ago

I don't see a problem with this. Like @Pandapip1 says, removing this function is backwards compatible and this definitely looks like a mistake on the authors' part.

merge

Pandapip1 commented 11 months ago

+1 for me. Will also assist @Dexaran if he wants to seperate this into its own standard as-is.

xinbenlv commented 11 months ago

I thought the ERC-223 is... final?

g11tech commented 11 months ago

i am fine removing something which accidentally got by and already notifies in EIP that implementations shouldn't depend on it

xinbenlv commented 11 months ago

I am fine to have it removed if it's accidental inclusion provided it's still very recently finalized. And let's avoid this next time together.

bumblefudge commented 11 months ago

cut-and-dry example of an "errata" edit-- not a normative change, doesn't break anything normative, grounded in the history of the PR