EIP Editing Office Hour Meeting 27

poojaranjan commented 8 months ago

Date & Time

Tuesday, Nov 14, 2023, at 15:00 UTC

Location

Zoom: TBA on EthCatHerders Discord #eip-editors Recording: https://www.youtube.com/playlist?list=PL4cwHXAawZxqnDHxOyuwMpyt5s8F8gdmO

Agenda

Visit EIPs
Rename it to ERC Editing Office Hour?

To `Final`

[x] https://github.com/ethereum/ERCs/pull/101

To `Last Call`

To `Review`

To `Withdrawan`

TBA

Misc PR

To `Draft`

Requested in comments

Added from the past meetings TBA

From `Satgnant`

TBA

Open Q&A

Other details

Announcement Blogpost

(Add your Pull Request number to be added to the agenda.)

saitama2009 commented 8 months ago

Hi @poojaranjan can https://github.com/ethereum/ERCs/pull/77 be included please thanks

tbergmueller commented 8 months ago

Hi @poojaranjan,

thanks for carrying over https://github.com/ethereum/ERCs/pull/43 from the last meeting, where we didn't get to it. Unfortunately I cannot attend today as I'm at a conference, would be great if @SamWilsn could address my question, I'd watch the recording later;

HTML-Proofer fails with the links (Link to run: https://github.com/ethereum/ERCs/actions/runs/6861154707/job/18656264411?pr=43). Note the error-messages still have EIPs in path, e.g. * At ./_site/EIPS/eip-6956.html:238: internal image ../assets/erc-6956/img/erc6956_concept.svg does not exist
Rebased the branch on master just today
I adopted to the new file structure, e.g. renaming links to erc-xxxx.md, ../assets/erc-6956/*, ...
Markdown including all links, images, assets works for me locally.
Is this an HTMLProofer-Issue, or do I need to take further action?

SamWilsn commented 8 months ago

@tbergmueller as far as I am aware (and @Pandapip1 or @lightclient can correct me), you should still be using ./eip-NNNN.md for links to other proposals, and ../assets/eip-NNNN/... for links to your assets. HTMLProofer can't really be trusted right now.

poojaranjan commented 8 months ago

Closing in favor of #296

ethcatherders / EIPIP