Call for Input: Update ERC-6492 (Final) Reference Implementation

ethcatherders / EIPIP

EIP Improvement Process

77 stars 36 forks source link

Call for Input: Update ERC-6492 (Final) Reference Implementation #321

Closed SamWilsn closed 3 months ago

SamWilsn commented 4 months ago

Call for Input

Decision	Do we merge https://github.com/ethereum/ERCs/pull/267 ?
If Affirmed	[ERC-6492](https://eips.ethereum.org/EIPS/eip-6492)'s reference implementation is updated.
If Rejected	No change.
Method	Rough Consensus
Deadline	March 22th, 2024

SamWilsn commented 4 months ago

For the same reasons I mention in https://github.com/ethcatherders/EIPIP/issues/291#issuecomment-1789265565 I am opposed to merging this pull request.

g11tech commented 4 months ago

reference implementation change and notices (security considerations for e.g. in 291) we should be able to update, will keep EIPs fresh but we need a good process to verify such a change

SamWilsn commented 3 months ago

So is your opinion here, @g11tech, that we should or should not merge this PR?

g11tech commented 3 months ago

i am opposed to the current PR but would prefer some sort of section which can list newer updates and links to it (some meta/info EIP updating the reference)

SamWilsn commented 3 months ago

Thanks for clarifying. Closing this one since the only responses are opposed, but I am open to discuss a more comprehensive policy.

Ivshti commented 3 months ago

@g11tech @SamWilsn what do you guys think about re-doing the PR in the following way:

no changes to the original text
new section under "security considerations" called "Audit report"
"Audit report" section contains a link to the PDF and an updated .sol file post-audit, perhaps to a diff between the included reference implementation and the new one
@SamWilsn's comment regarding license is resolved

SamWilsn commented 3 months ago

See https://github.com/ethcatherders/EIPIP/issues/291#issuecomment-1789265565 for a bit more detail on my reasoning, but the short form is Final means Final, and we only allow updates to correct errors in the specification.