Call for Input: Change Solidity in Final ERC-7201

ethcatherders / EIPIP

EIP Improvement Process

77 stars 36 forks source link

Call for Input: Change Solidity in Final ERC-7201 #327

Closed SamWilsn closed 2 months ago

SamWilsn commented 3 months ago

Call for Input

Decision	Do we merge https://github.com/ethereum/ERCs/pull/201 ?
If Affirmed	[ERC-7201](https://eips.ethereum.org/EIPS/eip-7201)'s specification section is modified.
If Rejected	No change.
Method	Rough Consensus
Deadline	April 12th, 2024

Background

Changing:

- keccak256(abi.encode(uint256(keccak256(id)) - 1)) & ~bytes32(uint256(0xff))
+ keccak256(abi.encode(uint256(keccak256(bytes(id))) - 1)) & ~bytes32(uint256(0xff))

SamWilsn commented 3 months ago

I am in favour of merging this pull request. It seems to correct an error in the original document without changing its meaning.

abcoathup commented 3 months ago

I support merging (I don't have a vote). Whilst I am generally against modifying final EIPs, this is a correction that is approved by one of the authors. Though we need a standard process for agreeing corrections.

g11tech commented 3 months ago

in favor of fixing typos, so yes to proposal

SamWilsn commented 2 months ago

The consensus on this issue seems to be merging, so merge I shall!