search

ethcatherders / EIPIP

EIP Improvement Process
77 stars 36 forks source link

Call For Input: Should we entertain the typo correction PRs #332

Closed g11tech closed 1 month ago

g11tech commented 3 months ago

Call for Input

Decision Should we merge the typo correction PRs which might just be people farming via contributions
If Affirmed we merge such PRs
If Rejected such PRs will be closed
Method Rough Consensus
Deadline May 8 2024

Context

Such kind of PRs https://github.com/ethereum/EIPs/pull/8254

may be we should add a spell checker in the first place?

g11tech commented 3 months ago

I am against entertaining such PRs and closing them off

xinbenlv commented 3 months ago

No strong preference, fine either way

SamWilsn commented 3 months ago

I am in favour of merging pull requests fixing typos. I don't even think they need a call for input, as long as an editor has checked the diff.

may be we should add a spell checker in the first place?

Theoretically we have one. Not sure why it isn't working.

SamWilsn commented 1 month ago

Doesn't seem to be a strong consensus either way. I'm going to close this for now, but can reopen if we need to.