Call for Input: Fix incorrect byte counts in EIP-712

SamWilsn commented 2 weeks ago

Call for Input

Decision	Do we merge https://github.com/ethereum/EIPs/pull/8722 ?
If Affirmed	The pull request https://github.com/ethereum/EIPs/pull/8722 is merged
If Rejected	No changes made to EIP-712
Method	Rough Consensus
Deadline	September 25th, 2024

Background

See https://github.com/ethereum/EIPs/pull/8722

Checklist

I, the opener of this Call for Input, have completed the following:

[x] Filled in a descriptive title.
[x] Filled in the "Decision" field.
[x] Filled in the "If Affirmed" field.
[x] Filled in the "If Rejected" field.
[x] Filled in the "Method" field.
[x] Filled in the "Deadline" field to be thirty days from creation.
[x] Added any relevant background information (or removed the section.)
[x] Published a notice in writing to the usual channels frequented by EIP Editors (likely Discord.)
[x] Commented on this Call for Input, clearly stating my opinion (or abstention.)

SamWilsn commented 2 weeks ago

In Favour

Grabbing a random signature from etherscan: https://etherscan.io/verifySig/257008

Checking this with Python gives:

>>> len(bytes.fromhex('466a43011085d6c9f480c044e6987462e6636e82065721525c4bbb4f8cf33cb339b4145bd90b172dc6878c690cb350256c69cbe2e88873b6b723856789d508901c'))
65

abcoathup commented 2 weeks ago

I'm against (but don't have a vote).

Reviewing such a change should not be on editors, it should be on the authors. If the authors approve a fix then editors could merge. I couldn't see anything from the original authors.

g11tech commented 2 weeks ago

in favor

even though I agree with @abcoathup , this is a fairly straightforward correction that any EL dev can verify. So i am in favor of the correction.

ethcatherders / EIPIP