ethdebug / format

Smart contract debugging data format – Standards development working group
https://ethdebug.github.io/format/
43 stars 4 forks source link

Switch to using web-solc in tests #100

Closed gnidan closed 2 months ago

gnidan commented 2 months ago

Instead of regular solc package, which won't work natively in the browser.

gnidan commented 2 months ago

This is probably not worth doing, since it requires adding test time to fetch solc, vs. just having it in the node_modules already.

(My original reason for thinking this might be a good idea was so that the website could provide interactive end-to-end testing for pointers against some user-specified Solidity code. I was looking to import my various test helpers directly, and the only thing that prevented doing this was solc. But using web-solc in the browser requires stopping the worker at some point, and so the test helpers would need to respect the fetching/cleanup lifecycle, and that's just a mess. So probably makes sense, if we do want interactive pointer examples like that on the site, just to do the compilation stuff entirely there and not go reaching into Node.js specific tests)