Closed chang closed 6 years ago
Cool! I'll look into this more over the weekend. But here are some initial thoughts based on glancing through the code:
@property
as oppose to normal class attribute.__init__
method, all it does is assign the input argument to a class attribute.convert
and write
method into 1 single method, and let it accept the path as an input argument. I think it makes sense when following sklearn's pattern, where we call .fit on the input data, thus here we call .convert on the input path. This would also avoid creating a new converter class for every single path since we could just pass the different path to the convert method.Love to hear your thoughts ~
Good points!
@property
is preferred over get_github_link()
, get_start_date()
, etc...write()
has the side effect of I/O@ericchang00 Discussion is moved to https://github.com/ethen8181/machine-learning/pull/5
This script will automatically convert IPython notebooks to the Airbnb Knowledge Repo format, injecting the required header and adding them to the knowledge repo. It currently works only with the .ipynb files in the repository.
A bit more needs to be done to get it into working order:
@ethen8181