search

ether-camp / ethereum-harmony

DEPRECATED! Ethereum Independent Peer
GNU General Public License v3.0
253 stars 89 forks source link

Strip off json-rpc filter data #106

Closed mkalinin closed 6 years ago

mkalinin commented 6 years ago

Inner data that is kept for JSON-RPC filter purposes holds full block and transaction objects which is memory leak prone.

screen shot 2018-07-07 at 21 23 08
zilm13 commented 6 years ago

Should be fixed with https://github.com/ether-camp/ethereum-harmony/commit/63791f9f0e1c9fa4b860717533857302141fa104 Also I've checked all other listener through whole app, there are places where latest 100 blocks are kept, but it's guaranteed that there are no more than 100 of them, so as we keep latest 192 in memory anyway, I don't think it's an issue.