search

ether / ep_adminpads2

Etherpad plugin to list and delete pads in /admin
MIT License
9 stars 8 forks source link

locales folder #2

Closed ovari closed 4 years ago

ovari commented 4 years ago

Could you please advise where the locales folder is so that we can add the hu (Hungarian - magyar) translation?

Thank you

rhansen commented 4 years ago

That's a very good question. I will do some research to figure out how localization works.

And I apologize for not replying earlier. I just learned today that GitHub had this repository set to "unwatched" so I wasn't getting any notifications. :angry:

rhansen commented 4 years ago

I found https://etherpad.org/doc/v1.8.4/#index_localizing_plugins. So far I haven't had any luck getting it to work for the static HTML file. You can see my work in progress in PR #6. You can try it yourself by running the following in your etherpad-lite directory:

npm install rhansen/ep_adminpads2#l10n

If you (or anyone else) knows what I'm doing wrong, please let me know.

ovari commented 4 years ago

@JohnMcLear can you please help with https://github.com/rhansen/ep_adminpads2/issues/2#issuecomment-674637875? Thank you

JohnMcLear commented 4 years ago

Best thing to do is look at how other plugins have implemented it. I'm not working on Etherpad at the moment due to other commitments, sorry!

rhansen commented 4 years ago

I figured out what was wrong and merged some localization changes. Feel free to open a pull request that adds locales/hu.json.