search

ether / ep_comments_page

Comments in Etherpad - No Longer Highly Experimental, now highly awesome!
Apache License 2.0
45 stars 48 forks source link

Translation updates #161

Closed ilmartyrk closed 4 years ago

ilmartyrk commented 4 years ago

Updated suggestion translation string to be more localizable, added popup positioning to appear under selected text, added check to not allow other users to edit comments

JohnMcLear commented 4 years ago

Hey @ilmartyrk a few things please.

1) cannot rebase and merge, you need to rebase your branch to master. 2) I don't like seeing features land with patches, IE the title here is "translation updates" but there is an entire new feature included nothing related to translations, I'd rather see that as a seperate PR.

Essentially this boils down to, "please send clean PRs for each thing you are trying to do", if you don't mind?

I really appreciate your effort here and I hate to bounce it back like this, but it's important we don't "blur the lines" too much especially as we're trying to improve our best practices in Etherpad and this is something that @muxator and @rhansen would be keen on seeing.

<3 and thanks!