ether / ep_comments_page

Comments in Etherpad - No Longer Highly Experimental, now highly awesome!
Apache License 2.0
45 stars 48 forks source link

Configure ESLint, fix ESLint errors #165

Closed rhansen closed 4 years ago

rhansen commented 4 years ago

Multiple commits that set up ESLint and fix the issues it complains about:

JohnMcLear commented 4 years ago

So a few things as we discussed..

1) awesome work! 2) I'd really like in the future to see fixes land separate from test modifications, just so we can see that the fixes/patches land and that the software functions as it was before. 3) I'm not strict about function(){} vs () => and for me that's fine.

TODO: Tests are failing :) Will need fixing up before merging!

rhansen commented 4 years ago

TODO: Tests are failing

Yup, though they are failing the same way on master.

JohnMcLear commented 4 years ago

Nice, afaik @ilmartyrk is working on the failing tests.