Closed rhansen closed 4 years ago
So a few things as we discussed..
1) awesome work!
2) I'd really like in the future to see fixes land separate from test modifications, just so we can see that the fixes/patches land and that the software functions as it was before.
3) I'm not strict about function(){}
vs () =>
and for me that's fine.
TODO: Tests are failing :) Will need fixing up before merging!
TODO: Tests are failing
Yup, though they are failing the same way on master
.
Nice, afaik @ilmartyrk is working on the failing tests.
Multiple commits that set up ESLint and fix the issues it complains about:
eslint --fix .
else
this
instead ofself
where possibleconst
andlet
instead ofvar
ep_comments
class toEpComments
getSelectedText
for readability, robustness