Suggestion text does not display

[LeaChemoul]

Context

• OS: Intel Mac OS X 10_14_6
• Browser : Mozilla/5.0, Chrome/86.0.4240.198
• Etherpad version: 1.8.6
• ep_comments_page version: 0.1.51

Behavior

When adding a suggestion, proposition text does not appear. But when clicking on "Apply", text is correctly replaced.

Steps to reproduce

Failure Logs

When opening developer tools : no errors.

Useful info

This was tested also on this public instance : https://lite1.infini.fr/p/test

[LeaChemoul]

@JohnMcLear To help you reproduce this. It seems that it occurs when my editor is in french. English is working fine.

[JohnMcLear]

I probably wont get to this any time soon so you might want to see if you can dig into it a bit :)

[LeaChemoul]

Thank you for your work @ldidry, seems like suggestions in French are displaying now :)

After more test, special characters (#175) are still a problem (maybe it's not related). I'm testing on 0.1.60 version. I will try to dig into it when I have time soon.

Here is an example, adding a suggestion with text "Hello ;)"

Regards

[ldidry]

That is not related to the translation missing and is known. See the explanation on https://github.com/ether/ep_comments_page/blob/master/templates/comments.html#L100-L102 (it’s to avoid security issues).

[davue]

Suggestions still do not show up for the German (Deutsch) and Polish (Polski) translation. I checked many but not all translations, there might be more languages where this doesn't work.

[Uatschitchun]

Hm... I do not get this. Although german translation was fixed, after installing the plugin, I do get those: and

From and To aren't shown...

And although pad is running in german this plugin is english?!