search

ether / ep_comments_page

Comments in Etherpad - No Longer Highly Experimental, now highly awesome!
Apache License 2.0
42 stars 48 forks source link

Read-only comments not shown #213

Closed ErikDW1 closed 2 years ago

ErikDW1 commented 2 years ago

Comments made in the read-only (RO) version of the pad are not transposed to the read-write (RW) version and also disappear after page refresh, even though are stored into the db.

Steps to reproduce:

  1. Open a browser window with the RO link of the pad, then open another browser window with the RW link;
  2. If you make a comment in the RW version of the pad this is immediately shown also in the RO version but not vice-versa;
  3. If you refresh the RO window all the comments made are not shown anymore, except the ones made in the RW version;
  4. Check the db and see that in the "comments" key however ALL comments are stored, both RW and RO.

The same cannot be said for the comment replies: if a RO user replies to a comment made by a RW user, the reply is shown immediately and also sticks after page refresh.

ErikDW1 commented 2 years ago

Great! Thanks a lot! Just a quick tip: simply updating the plugin from the admin panel doesn't seem to make the fix working; I had to do a restart of the etherpad service.