ether / ep_comments_page

Comments in Etherpad - No Longer Highly Experimental, now highly awesome!
Apache License 2.0
45 stars 48 forks source link

UX: Add disabled button #96

Open rugk opened 8 years ago

rugk commented 8 years ago

The behaviour of the toolbar button should be improved.

When no text is selected

Current behaviour: Button as usual (enabled) Best behaviour: Disabled

When text is selected

Current behaviour: Button as usual (enabled) Best behaviour: Button as usual (enabled)

This behaviour could further be improved by having a floating button. See https://github.com/JohnMcLear/ep_comments/issues/95.

lpagliari commented 8 years ago

@rugk This is a good idea, could you help us on that? This hook might be what you need: http://etherpad.org/doc/v1.6.0/#index_aceselectionchanged