search

ether / ep_email_notifications

Subscribe to a pad and recieve an email when someone edits your pad
Apache License 2.0
10 stars 14 forks source link

The plugins breaks EP when you try to subscribe an email to the pad #17

Closed Yaco closed 10 years ago

Yaco commented 10 years ago

This the output that desbribes the error:

[2014-03-17 19:22:32.299] [ERROR] console - TypeError: undefined is not a function
    at Object.exports.checkEmailValidation (/home/etherpad/etherpad-lite/node_modules/ep_email_notifications/handleMessage.js:333:19)
    at Object.exports.subscriptionEmail (/home/etherpad/etherpad-lite/node_modules/ep_email_notifications/handleMessage.js:163:34)
    at Object.callback (/home/etherpad/etherpad-lite/node_modules/ep_email_notifications/handleMessage.js:83:25)
    at /home/etherpad/etherpad-lite/src/node_modules/ueberDB/CloneAndAtomicLayer.js:100:17
    at exports.database.get (/home/etherpad/etherpad-lite/src/node_modules/ueberDB/CacheAndBufferLayer.js:144:5)
    at doOperation [as operatorFunction] (/home/etherpad/etherpad-lite/src/node_modules/ueberDB/CloneAndAtomicLayer.js:94:18)
    at exports.channels.emit (/home/etherpad/etherpad-lite/src/node_modules/ueberDB/node_modules/channels/channels.js:38:11)
    at exports.database.get (/home/etherpad/etherpad-lite/src/node_modules/ueberDB/CloneAndAtomicLayer.js:62:17)
    at Object.exports.handleMessage [as hook_fn] (/home/etherpad/etherpad-lite/node_modules/ep_email_notifications/handleMessage.js:40:14)
    at normalizedhook (/home/etherpad/etherpad-lite/src/static/js/pluginfw/hooks.js:15:27)
[2014-03-17 19:22:32.300] [INFO] console - graceful shutdown...
[2014-03-17 19:22:32.359] [INFO] console - db sucessfully closed.

This is what I have in my settings.json file:

"ep_email_notifications" : {
    "checkFrequency": "6000", // checkFrequency = How frequently(milliseconds) to check for pad updates -- Move me to the settings file
    "staleTime": "30000",  // staleTime = How stale(milliseconds) does a pad need to be before notifying subscribers?  Move me to settings
    "fromName": "Redes de Pares",
    "fromEmail": "pad@beta.redesdepares.org",
    "urlToPads": "http://pad.redesdepares.org/p/", // urlToPads = The URL to your pads note the trailing /
    "emailServer": { // See https://github.com/eleith/emailjs for settings
        "host": "127.0.0.1"
    }
},
JohnMcLear commented 10 years ago

confirmed.

JohnMcLear commented 10 years ago

Fixed in 0.1.1