search

ether / ep_email_notifications

Subscribe to a pad and recieve an email when someone edits your pad
Apache License 2.0
10 stars 14 forks source link

no mails are send #7

Closed quenenni closed 11 years ago

quenenni commented 11 years ago

I can't make it work.

I added in my settings.json the "ep_email_notifications" section.

I noticed the same problem with the emailjs plugin (dependency of your plugin not in the right place)

So I installed it manually: npm install emailjs

When modifying a page, I have the notification asking me for my email address. In the store table in my Db, I can see the record 'emailSubscription' with my address (I did it with 2 different browsers and 2 different user / email addresses)

But no mails are send. /var/log/mail.log shows nothing.

In the etherpad logs, I can see: [2013-03-19 21:59:49.864] [WARN] message - Dropped message, unknown COLLABROOM Data Type USERINFO_AUTHOR_EMAIL_IS_REGISTERED_TO_PAD

Etherpad-lite v1.2.9 Plugin installed via the plugin page from the admin interface.

JohnMcLear commented 11 years ago

Warning issue resolved, not sure why your emails aren't flowing. I guess check your sendmail or so settings.

quenenni commented 11 years ago

It's not my mail server (postfix in my case). It send mails flowingly and in this case, there is no attempt to send a mail as my mail.log doesn't show anything.

I was wondering if the problem can come from the plugin emailjs. As I mentioned earluer, I had to install ut manually via the command 'npm install' But when I start my etherpad-lite, it lists all the plugins it recognizes, and emailjs is not listed.

So maybe, when your plugin try to use a fonction from emailjs, it doesn't work. But why don't I see anything in the etherpad logs?

JohnMcLear commented 11 years ago

I'm not sure, it's working okay for me. Feel free to add debug comments to the code and find out.

quenenni commented 11 years ago

hmmm..

I removed all the plugins and just install this one (without installing emailjs manually).

The mails were send. That's great.

I'm going to install all the plugins I had installed previously and try to see if one is creating the problem.

PS: when activating the DEBUG log level in ethepad-lite, it becomes insane. I never saw such a mess. I had 50 000 lines in 40 seconds. How the hell are we supposed to help debugging with that??

JohnMcLear commented 11 years ago

use grep http://en.wikipedia.org/wiki/Grep

quenenni commented 11 years ago

Ho.. That's great.. Your plugin, when sending a mail, use the INFO log level, not the DEBUG level. So it will be easy to test with all the other plugins.

I'll do that tonight.

I notice I still have the msg: [2013-03-20 19:46:02.617] [WARN] message - Dropped message, unknown COLLABROOM Data Type USERINFO_AUTHOR_EMAIL_IS_REGISTERED_TO_PAD Maybe that's not important as the mails are sent.

PS: I know grep and regular expressions, but when you don't know what to look after, it's tricky :)

JohnMcLear commented 11 years ago

afaik that bug should be fixed...

John McLear McLear Ltd Etherpad Foundation Primary Technology Ltd

Date: Wed, 20 Mar 2013 11:52:29 -0700 From: notifications@github.com To: ep_email_notifications@noreply.github.com CC: john@mclear.co.uk Subject: Re: [ep_email_notifications] no mails are send (#7)

Ho.. That's great..

Your plugin, when sending a mail, use the INFO log level, not the DEBUG level.

So it will be easy to test with all the other plugins.

I'll do that tonight.

I notice I still have the msg:

[2013-03-20 19:46:02.617] [WARN] message - Dropped message, unknown COLLABROOM Data Type USERINFO_AUTHOR_EMAIL_IS_REGISTERED_TO_PAD

Maybe that's not important as the mails are sent.

PS: I know grep and regular expressions, but when you don't know what to look after, it's tricky :)

— Reply to this email directly or view it on GitHub.

quenenni commented 11 years ago

I have v0.0.6 installed. It seems it's the new one, with the correction you made.

quenenni commented 11 years ago

I tested the installation of lots of plugins and I continue to receive the mails when someone start editing a pad.

I don't know where my problem came from, but afaik now, it works flowlessly with 14 plugins installed.

Sorry for the noise and thanks for your help.

I'm just going to try to remove the mails when someone finished to edit a pad. If I wrote a sentence, wait few minutes, wrote another sentence, wait fex minutes, do a correction, ..., I receive really too many mails.

Except from that, that's a really great plugin.