search

ether / ep_file_menu_toolbar

File Menu Toolbar plugin for Etherpad
Other
4 stars 8 forks source link

locales folder #8

Open ovari opened 4 years ago

ovari commented 4 years ago

Please add a locales folder to enable translations.

Thank you

JohnMcLear commented 4 years ago

This is harder than I expected. The translations apply to the title / hover but they aren't applying to the text content in the file menu... :(

woeterman94 commented 4 years ago

Can't you use the locals from the plugins for that? (For example colors, headings,...)

JohnMcLear commented 4 years ago

Yea that's what I'm doing but sometimes it doesn't apply.. I will push an example and if you want you can complete it?

JohnMcLear commented 4 years ago

https://github.com/JohnMcLear/ep_file_menu_toolbar/commit/5dfdb2c8dd25f0b50b6909671f47aafaffe50f3f

Ref above, I did a handful but the rest need doing .

Ref to https://github.com/ether/etherpad-lite/blob/develop/src/locales/en.json for string IDs

JohnMcLear commented 4 years ago

@woeterman94 do you think you can finish the rest up please?

woeterman94 commented 4 years ago

I'll take a look at it

woeterman94 commented 4 years ago

Is this what you mean? https://github.com/JohnMcLear/ep_file_menu_toolbar/pull/10

JohnMcLear commented 4 years ago

Exactly :+1: