search

ether / etherpad-lite

Etherpad: A modern really-real-time collaborative document editor.
http://docs.etherpad.org/
Apache License 2.0
16.69k stars 2.85k forks source link

Timeslider broken: on certain pads, no changes are replayed when timeslider pin moves or is moved. Loss of socket.io connectivity? #1077

Closed Wikinaut closed 11 years ago

Wikinaut commented 12 years ago

I just noticed, that the Timeslider function is broken. It does not work, shows an empty content frame, or the current content (static) but flickering without displaying any changes.

JohnMcLear commented 12 years ago

So the problem is on pads with lots of content/changes or what? If so then we close this and work at #'1068

Wikinaut commented 12 years ago

I suppose there is a currently undetected "no connection request" issue when moving the timeslider pin. Why?

When the effect (timeslider moved but not content changes are shown) appears I did not observe the usual "connection" flickering in the tab or status bar (the flickering has been reported already when we changed socket.io protocol to jsonp-polling, but cannot be changed, because it is browser-inherent).

In other words:

  1. pad timesliders do work, when you see flickering in the tab or status bar when you move the timeslider pin, or when you have started to replay the changes.
  2. pad timesliders do not work, when you do not see such a flickering.

Résumé:

I suppose a loss of communication or response, protocol or timing misbehaviour in these cases. Currently, the problem does not appear being caused by corrupted changesets because it happens on several different and independent EPL and server installations.

Wikinaut commented 12 years ago

still not (always) working

Wikinaut commented 12 years ago

Status: when the timeslider is not working, and when I moved the slider pin the pad crashes with such a message.

Is it of help to locate the reason ?

[2012-11-01 23:22:10.188] [ERROR] console - TypeError: Cannot read property 'length' of undefined
    at nextText (/srv/etherpad/src/static/js/Changeset.js:1943:24)
    at Object.exports.inverse (/srv/etherpad/src/static/js/Changeset.js:1995:22)
    at async.series.callback.forwardsChangesets (/srv/etherpad/src/node/handler/PadMessageHandler.js:1279:35)
    at async.series.results (/srv/etherpad/src/node_modules/async/lib/async.js:486:21)
    at _asyncMap (/srv/etherpad/src/node_modules/async/lib/async.js:185:13)
    at async.forEachSeries.iterate (/srv/etherpad/src/node_modules/async/lib/async.js:108:13)
    at async.forEachSeries.iterate (/srv/etherpad/src/node_modules/async/lib/async.js:119:25)
    at _asyncMap (/srv/etherpad/src/node_modules/async/lib/async.js:187:17)
    at async.series.results (/srv/etherpad/src/node_modules/async/lib/async.js:491:34)
    at _asyncMap (/srv/etherpad/src/node_modules/async/lib/async.js:190:13)

Can you please reopen this issue, thanks.

marcelklehr commented 12 years ago

@johnyma22 There's definitely something wrong with the timeslider

disy-mk commented 12 years ago

anything new here? is actually someone trying to fix it or do we need more information or anything else?

JohnMcLear commented 12 years ago

Well as far as I understand it, it's part of a bigger problem where we don't deliver/store PAD REV data and the client hasn't had time to load in all changesets by the time people try to use the timeslider. Someone is working on a pad revision branch but I don't know if it will get into core or even if I'm on the right tracks. I haven't specifically tried debugging, I simply have a theory based on experience of seeing this cause problems on timesliders. See:

https://github.com/Pita/etherpad-lite/issues/1068

JohnMcLear commented 12 years ago

I don't think @Wikinaut 's steps to replicate will work and could be misleading. @Wikinaut it might be worth going through some of your comments on this thread and making them factual.

I think you will need to: 1) checkout any version of etherpad lite 2) commit a lot of changes to a pad then hit the timeslider.

Can we confirm that so we are on the right tracks?

Wikinaut commented 12 years ago

@johnyma22

Well as far as I understand it, it's part of a bigger problem where we don't deliver/store PAD REV data and the client hasn't had time to load in all changesets by the time people try to use the timeslider.

I suppose (and hope), that it has only to do with late or otherwise interrupted delivering of pad rev data, but (luckily) not with storing of it, as all my pad are working as such. Yes, with IE8 (! all flavours), Firefox and Chrome. This at least is good news.

Wikinaut commented 12 years ago

@johnyma22

As said twice: you can try to replicate on your own pad which is broken as well http://beta.etherpad.org/p/test/timeslider

Wikinaut commented 12 years ago

There's no need that I go to my pad: you can scrutinize your own pad data for http://beta.etherpad.org/p/test/timeslider , please.

Deepsurfer commented 12 years ago

i will testet again in view days, but i mean that the TimeSlider works with "dirty" DB. by change to mysql DB i have the same issue that the needle is taking his way but no text and no changes is seeing.

in the mysqlDB is seeing the stored changes (many tables..)

grrets Deep

Wikinaut commented 12 years ago

Indeed a good point, I do use MySQL.

Developers, heads up! Is a MySQL driver bug ?

JohnMcLear commented 12 years ago

You tell us. You have the same tools we have!

Deepsurfer commented 11 years ago

Resume, its not an issue with MySQL ! now step by step testing till broken TimeSlide Sorry for long Comment, but think must be good to see what happen

Browser: FireFox 17.0.2 and IRON 15.0.900.2 (Developer-Build 107001 Windows) Chrome Clone

Clean install without any changes = Dirty-DB TimeSlider works perfect !

[code] Ensure that all dependencies are up to date... npm WARN package.json ep_etherpad-lite@1.1.5 No README.md file found! npm WARN package.json async-stacktrace@0.0.2 'dev-dependencies' should probably be 'devDependencies' Ensure jQuery is downloaded and up to date... Clear minfified cache... ensure custom css/js files are created... start... [2012-11-08 21:39:29.618] [WARN] console - DirtyDB is used. This is fine for testing but not recommended for production. [2012-11-08 21:39:30.491] [INFO] console - Installed plugins: ep_etherpad-lite [2012-11-08 21:39:30.511] [WARN] console - Can't get git version for server header EISDIR, illegal operation on a directory [2012-11-08 21:39:30.511] [INFO] console - Report bugs at https://github.com/Pita/etherpad-lite/issues [2012-11-08 21:39:30.549] [INFO] console - info - 'socket.io started' [2012-11-08 21:39:30.557] [INFO] console - You can access your Etherpad-Lite instance at http://0.0.0.0:9001/ [2012-11-08 21:39:30.557] [WARN] console - Admin username and password not set in settings.json. To access admin please uncomment and edit 'users' in settings.json [/code]

Change ADMIN function and change to MySQL TimeSlider works perfect !

[code] Ensure that all dependencies are up to date... npm WARN package.json ep_etherpad-lite@1.1.5 No README.md file found! npm WARN package.json async-stacktrace@0.0.2 'dev-dependencies' should probably be 'devDependencies' Ensure jQuery is downloaded and up to date... Clear minfified cache... ensure custom css/js files are created... start... [2012-11-08 21:44:04.937] [INFO] console - Installed plugins: ep_etherpad-lite [2012-11-08 21:44:04.964] [WARN] console - Can't get git version for server header EISDIR, illegal operation on a directory [2012-11-08 21:44:04.964] [INFO] console - Report bugs at https://github.com/Pita/etherpad-lite/issues [2012-11-08 21:44:05.000] [INFO] console - info - 'socket.io started' [2012-11-08 21:44:05.006] [INFO] console - You can access your Etherpad-Lite instance at http://0.0.0.0:9001/ [2012-11-08 21:44:05.006] [INFO] console - The plugin admin page is at http://0.0.0.0:9001/admin/plugins [/code]

Change to ABIWORD (for export and import) TimeSlider works perfect

At this point all is good, now i install useful plugins via /admin/plugins Interface not over console ! -- console write that install is good, but etherpad-lite must be restart because the browser have after restart the plugin in pad interface

  1. ep_headings -- TimeSlide works
  2. ep_monospace_default -- TimeSlide works
  3. ep_tables -- TimeSlider DONT Work anymore / after uninstall TimelSlide works

i read in any issue text that any plugins are broken, but i don't find any list of this problem between etherpad-lite 1.1.5 and the plugin List.

i can make a little list of working <--> broken plugins, but i do not test all 37 plugins because many of them not useful for me.

comment this list later greets Deep

Wikinaut commented 11 years ago

Hmmmmm,

I found this:

then suddenly pad revisions are shown. And after then, this pad's timeslider works also in "play" mode

Deepsurfer commented 11 years ago

So short list:

Dont know if this a new issue: by stopping the etherpad-lide with STRG-C it comes this red message

^C[2012-11-08 23:00:39.215] [INFO] console - graceful shutdown... [2012-11-08 23:00:39.231] [ERROR] console - TypeError: object is not a function at ChildProcess. (/home/etherpadlite/src/node/utils/Abiword.js:95:7) at ChildProcess.EventEmitter.emit (events.js:99:17) at Process._handle.onexit (child_process.js:678:10) [2012-11-08 23:00:39.258] [INFO] console - db sucessfully closed.

any suggestions ?

greets Deep

Wikinaut commented 11 years ago

any news ?

JohnMcLear commented 11 years ago

@Deepsurfer what does working plugins have to do with broken timeslider?

@wikinaut no update from me I'm not working on this as I'm still not even sure how to replicate the bug and tbh I'm working on other things.

Wikinaut commented 11 years ago

@johnyma22 you wrote you cannot replicate, hey, head up, it's broken here http://beta.etherpad.org/p/test/timeslider and you can replicate it all day and night long.

btherres commented 11 years ago

Same issue here:

System

Problem

Seems as you should give the timeslider a bit more time to load before is starts playing...?

Wikinaut commented 11 years ago

@btherres wrote Seems as you should give the timeslider a bit more time to load before is starts playing...?

I think it can be due to an interruption in the communication. Why ? I noticed that no flickering is visible when moving the timeslider needle. So it can also be a javascript client issue (moving the needle -> but not sending to server).

I leave this to the experts (Pita, John, Marcel...). Let me know, if I can help anything to find the bug...

Deepsurfer commented 11 years ago

<< from johnymar22 @Deepsurfer what does working plugins have to do with broken time slider? >>

My List is with EtherPadLite 1.1.5 (at this time was actual version) and in this list from me it can see that any popular plugins working with 1.1.5 up to ep_tables. And with this Information i hope that many other users with the broken time slider checking installed plugins list.

the second list, i wrote that i test not all plugins, but any plugins i testet and review a status, in all cases for therpad-lite 1.1.5. I do that because i found a list for old etherpadlite version and not actual.

Now etherpadlite is on Version 1.2 and i think, after your question, a new list with working and/or broken plugins is undesired.

sorry for my bad english, hope significant detail are understanding greetings from germany Deep

Wikinaut commented 11 years ago

@johnyma22 @Deepsurfer heads up, I can can now confirm your observation, that the ep_tables plugin breaks timeslider immediately. This has to do with an ep_tables related anonymous function which is incorrectly loaded, I saw this in the Firebug console. (I am currently trying to find the timeslider bug and came accross this secondary problem, which I filed as https://github.com/gedion/ep_tables/issues/10 issue separately with in the ep_tables issue tracker)

coiby commented 11 years ago

If I remove ep_tables plugin, the timeslider works nicely!

JohnMcLear commented 11 years ago

FYI @gedion - If you find buggy plugins you need to contact the plugin maintainer and/or create an issue on their github which is exactly what @Wikinaut did.

Can we please confirm the timeslider is fine as long as you don't enable a plugin that breaks it? (as is the nature of any plugin framework we devolve responsibility for pad integrity to the plugin and you always use plugins at your own risk).

Perhaps we need a section on the wiki for reporting bugs with plugins?

JohnMcLear commented 11 years ago

Note I have added this as a 1.3 Milestone as to appease @Wikinaut ;)

Wikinaut commented 11 years ago

@johnyma22 wrote

Can we please confirm the timeslider is fine as long as you don't enable a plugin that breaks it?

No, we cannot confirm. Timeslider is still broken by a first and currently unknown problem which is independent of ep_tables plugin.

Wikinaut commented 11 years ago

Some observations

1

When you use the back-in-time button (left arrow) as the first action after loading the timeslider page, you can step backwards, at least a large number of revisions.

2

If you now move the pin, the function is broken. Neither back button, nor forwards button, nor pin triggers a change of the content.

3

If you use the pin as the first action, you break it immediately. Clicking the back-in-time button is ignored, and nothing happens any more.

Wikinaut commented 11 years ago

now handled in #1217. Closing this one.

disy-mk commented 11 years ago

Anything new here?

I just set up a new instance of epl (master branch) and added following plugins:

cleared the cache then, loaded an old known pad and went straight to the time slider (where I noticed a slight offset of the needle to the left - unrelated to this issue) and saw that the time slider history is not showing up; I remembered that this was once said to be ep_table's fault and I went to the pluginspage of my instance (in a new tab), uninstalled ep_table and switched to my pad-tab, reloaded and voilà, the history appeared and time slider is working

@johnyma22 wrote

Can we please confirm the timeslider is fine as long as you don't enable a plugin that breaks it?

No, we cannot confirm. Timeslider is still broken by a first and currently unknown problem which is independent of ep_tables plugin.

marcelklehr commented 11 years ago

Oh! That's interesting. Perhaps bum the authors of ep_tables then... (@gedion?)

disy-mk commented 11 years ago

Just wanted this to be confirmed, because some comments earlier IT was said these wer not related.

rasos commented 11 years ago

Needed to remove ep_tables plugin to make timeslider work again.

disy-mk commented 11 years ago

Yeah, a big problem… dropped the maintainer of ep_tables some messages about that….

to be more specific this is #1077 aka gedion/ep_tables#10
bflorat commented 6 years ago

Same here with etherpad 1.6.3, the ep_table plugin broke the timeslider. Spent 2 hours before finding the previous comments. If this plugin is no more supported, perhaps should it by dropped from the official list ?