search

ether / etherpad-lite

Etherpad: A modern really-real-time collaborative document editor.
http://docs.etherpad.org/
Apache License 2.0
16.59k stars 2.84k forks source link

Is our saved revision star confusing? #1422

Closed JohnMcLear closed 10 years ago

JohnMcLear commented 11 years ago

Would it better to have a save icon?

marcelklehr commented 11 years ago

I dunno, I got used to it over time... maybe we shouldn't call it a 'saved' revision -- after all we store all revisions permanently and a 'Mark this revision as a saved revision' button is therefore kinda confusing... What about Marked revisions?

luto commented 11 years ago

The icon is fine, a new adjective would be good, as marcel said. Tagged, Marked, Flagged,..

JohnMcLear commented 11 years ago

I guess we really need to do some usability studies to answer this question fully ;\ Anyone got any experience in doing them?

iquidus commented 11 years ago

No experience with usability studies but thought I'd provide some feedback. Currently on hover it says 'saved revisions' but upon click, it saves the revision, the wording should be changed to 'save revision' as that is what the button does, the current wording suggests it will list or display the 'saved revisions' for that pad. Also I agree with marcel/mluto 'tagged' or 'marked' makes more sense than 'saved' (keeping my previous comment about wording in mind). I generally associate 'flagged' with bad.. e.g 'the comment has been flagged for being offensive' so it might be better to avoid flagged.I dont think the icon matters much if the wording is fixed up, the star will be just fine.

JohnMcLear commented 11 years ago

+1 change it to save revision

icanb commented 11 years ago

My "usability studies" show that people get confused when there is no save button. People generally don't seem to realize there is a star button nor have any idea about what it's doing.

Google Docs solves this by putting "Save x mins ago", but it's not the case with etherpad.

Especially non-techie users who are used to software like MS Word don't understand that it gets saved automatically and looks for a save button. I replaced the star with a save icon on my version and it seems to work well.

JohnMcLear commented 11 years ago

@icanberk fancy sharing your save icon? We could use gritter to display a notification to tell users that pad contents is saved automatically and give them an option to never notify them again if they acknowledge it (checkbox)/

JohnMcLear commented 11 years ago

Yea @icanberk I have seen that a fair amount of times.. even I found myself hitting control s frequently so I added save revision functionality on control S but this isn't a positive enough enforcement..

icanb commented 11 years ago

Sure, I'll send a pull request soon.

sesam commented 11 years ago

+1 changing star to "save" and rewording on hoover texts to match

/Simon

On Mon, Feb 4, 2013 at 1:58 PM, Ilter notifications@github.com wrote:

Sure, I'll send a pull request soon.

— Reply to this email directly or view it on GitHubhttps://github.com/ether/etherpad-lite/issues/1422#issuecomment-13075658.

JohnMcLear commented 11 years ago

So on develop it "is" save revision, I may be missing something @iquidus..

I'm still gonna replace the star with a save icon though..

iquidus commented 11 years ago

John, you are correct. It does now say 'Save Revision', I guess somebody fixed that up already. On another note, ep_help_bubbles needs rewording (says 'saved revisions') +1 save icon

JohnMcLear commented 11 years ago

@iquidus done.

JohnMcLear commented 11 years ago

@0ip can you please sort out a new icon for the pad and timeslider please?