Follow Link in Pad

[Dr-Sommer]

Hi, is it better to post "Feature requests" here, or in the Wiki?

An option (like doubleklick on a link) to follow a given link would be nice..

http://www.caba.de/tmp/charity.jpg

is it save to make a Update with "git pull origin master"??

You know my debacle from last time... ;)))

[JohnMcLear]

Here is best

[Pita]

@Maja88 Sorry, I don't understand what you mean. What you want to change?

[Dr-Sommer]

Hi, Pita... ;)

when i write a link such as " http://www.CaBa.de " in a pad, and if i want to follow this link, i have to Copy&Paste it from the Pad into the browser... is there a way just to Doubleklick the link in the pad to directly open the link??

ThX ;)

[JohnMcLear]

Not yet, this functionality needs writing. Feel free to take a look at some examples of it and have a go writing it

[JohnMcLear]

I actually wrote this for primarywall a few days ago, it might be possible to re-use the code I used.. Have assigned myself

[Pita]

Afaik is this working and always worked. Look here at j.mp link http://beta.etherpad.org/p/2vwbCEF5Bj

[JohnMcLear]

Works with http://etherpad.org but not www.etherpad.org

This worked well for me: http://stackoverflow.com/questions/1500260/detect-urls-in-text-with-javascript

[Pita]

@johnyma22 do you really think this is a problem for users? I mean we can create a regular expression that gets this links too.... but imho again work > usefull

[JohnMcLear]

Yep, I do :) It's another 5 minute job that will make the users happier

[JohnMcLear]

Fixed in: https://github.com/Pita/etherpad-lite/commit/d5e303ec9f6c9abae5a57e01d59670b222d05323

[JohnMcLear]

https://github.com/Pita/etherpad-lite/commit/d5e303ec9f6c9abae5a57e01d59670b222d05323 has a bug where the browser takes the current URL and passes that with the URL.

[JohnMcLear]

Okay I fixed it with: https://github.com/Pita/etherpad-lite/commit/55a2f46ca90391e9446eff874b83e45a0161d252

make sure to include the older commit.

Please test this, it's live on htp://beta.etherpad.org

Test it by typing in www.etherpad.org

[crash-dive]

It works fine for me in chrome and firefox, however I cannot get IE to even load a pad at the moment.

One suggestion I would make is to override the default browser a:visited pseudo-class as it is not that common on websites to use it any more, this one does not for example.

[JohnMcLear]

Hit F5 in IE.

It was broken because I left my debug comments in.

Should be fine now

-----Original Message----- From: Jonathon Smith [mailto:reply@reply.github.com] Sent: 20 November 2011 15:03 To: John McLear Subject: Re: [etherpad-lite] Follow Link in Pad (#143)

It works fine for me in chrome and firefox, however I cannot get IE to even load a pad at the moment.

One suggestion I would make is to override the default browser a:visited pseudo-class as it is not that common on websites to use it any more, this one does not for example.

---

Reply to this email directly or view it on GitHub: https://github.com/Pita/etherpad-lite/issues/143#issuecomment-2804234 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

[JohnMcLear]

Btw, don’t press enter. That is a bug made by @pitapoison that is being rejected.

-----Original Message----- From: Jonathon Smith [mailto:reply@reply.github.com] Sent: 20 November 2011 15:03 To: John McLear Subject: Re: [etherpad-lite] Follow Link in Pad (#143)

It works fine for me in chrome and firefox, however I cannot get IE to even load a pad at the moment.

One suggestion I would make is to override the default browser a:visited pseudo-class as it is not that common on websites to use it any more, this one does not for example.

---

Reply to this email directly or view it on GitHub: https://github.com/Pita/etherpad-lite/issues/143#issuecomment-2804234 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

[JohnMcLear]

Can someone please test this?

[crash-dive]

I did more testing and there are a few issues that comes up. If you type anything starting with www then that entire phrase becomes an anchor tag, even if there is a space after the www. So for example in the sentence "Put www at the start of the address" "www at" would become an anchor. The regex need updating to require a dot after the www, which I think would fix the issue, but my regex knowledge is not great.

Also you are attaching a title atribute which gives the tool tip "test" to the anchor, I assume you want that to say something else?

Finally after something has been linked it makes it hard to edit that link as clicking on it causes you to navigate to the link, the alternative to that is make ctrl-click navigate and use a tool tip to inform the user. But that depends on what everyone else thinks.

When I started writing this IE9 still does not work correctly, however it seems to work now. I could test the link feature and it works the same as it does in FF and Chrome.

[JohnMcLear]

That should just be www. Afaik in the regex, can you test that?

If you want I can update the code and push. Thanks for testing

It shouldn't say Test..

Give me 20 minutes and I will commit a fix, just doing something

-----Original Message----- From: Jonathon Smith [mailto:reply@reply.github.com] Sent: 22 November 2011 20:30 To: John McLear Subject: Re: [etherpad-lite] Follow Link in Pad (#143)

I did more testing and there are a few issues that comes up. If you type anything starting with www then that entire phrase becomes an anchor tag, even if there is a space after the www. So for example in the sentence "Put www at the start of the address" "www at" would become an anchor. The regex need updating to require a dot after the www, which I think would fix the issue, but my regex knowledge is not great.

Also you are attaching a title atribute which gives the tool tip "test" to the anchor, I assume you want that to say something else?

Finally after something has been linked it makes it hard to edit that link as clicking on it causes you to navigate to the link, the alternative to that is make ctrl-click navigate and use a tool tip to inform the user. But that depends on what everyone else thinks.

When I started writing this IE9 still does not work correctly, however it seems to work now. I could test the link feature and it works the same as it does in FF and Chrome.

---

Reply to this email directly or view it on GitHub: https://github.com/Pita/etherpad-lite/issues/143#issuecomment-2840117 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

[JohnMcLear]

Yep www. fixes it the www issue. https://github.com/Pita/etherpad-lite/commit/2db81050f1e53605237ea621de26c06898f7741a

[JohnMcLear]

"Also you are attaching a title atribute which gives the tool tip "test" to the anchor, I assume you want that to say something else?

Finally after something has been linked it makes it hard to edit that link as clicking on it causes you to navigate to the link, the alternative to that is make ctrl-click navigate and use a tool tip to inform the user. But that depends on what everyone else thinks.

When I started writing this IE9 still does not work correctly, however it seems to work now. I could test the link feature and it works the same as it does in FF and Chrome."

The "test" as title issue hasn't been committed, removed code from my dev site.

@Pita, afaik https://github.com/Pita/etherpad-lite/commit/2db81050f1e53605237ea621de26c06898f7741a should be good to merge

[Pita]

@johnyma22 Is this feature on beta.etherpad.org?

[JohnMcLear]

yessir

-----Original Message----- From: Peter 'Pita' Martischka [mailto:reply@reply.github.com] Sent: 23 November 2011 19:17 To: John McLear Subject: Re: [etherpad-lite] Follow Link in Pad (#143)

@johnyma22 Is this feature on beta.etherpad.org?

---

Reply to this email directly or view it on GitHub: https://github.com/Pita/etherpad-lite/issues/143#issuecomment-2853564 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

[Pita]

ok, works fine. Good job. I close this

[JohnMcLear]

Thanks.

[Wikinaut]

Hello,

please see http://www.htmlhelp.com/tools/validator/problems.html#amp .

"&" in URLs must be encoded as

&

The non-URLencoding made AbiWord crashing on Pad with URLs with "&" in the URLs, see https://github.com/Pita/etherpad-lite/issues/260 and https://github.com/Pita/etherpad-lite/issues/189 .

[JohnMcLear]

A new issue needs to be made for this

[Pita]

Yoda, you speak like

[Dr-Sommer]

Hi there again... ;)

Strange... on your testlink above the Link klicking is functioning... But here on my board this is not functioning:

http://www.caba.de/phpBB3/viewtopic.php?f=148&t=2065

i can't thing of anything that could be wrong...

Not functioning with Firefox, Opera and IE... just yesterday i did an "git pull origin master"... ;)

Could you pleas look at this issue of mine? ThX.. ;)

[JohnMcLear]

Must be because you have the pad embedded, try open the pad up outside of your forum and see if it works or not

-----Original Message----- From: Maja88 [mailto:reply@reply.github.com] Sent: 13 January 2012 14:11 To: John McLear Subject: Re: [etherpad-lite] Follow Link in Pad (#143)

Hi there again... ;)

Strange... on your testlink above the Link klicking is functioning... But here on my board this is not functioning:

http://www.caba.de/phpBB3/viewtopic.php?f=148&t=2065

i can't thing of anything that could be wrong...

Not functioning with Firefox, Opera and IE... just yesterday i did an "git pull origin master"... ;)

Could you pleas look at this issue of mine? ThX.. ;)

---

Reply to this email directly or view it on GitHub: https://github.com/Pita/etherpad-lite/issues/143#issuecomment-3480087 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools

[Dr-Sommer]

Arghh.... yes... its working outside the iframe... ;( is there any way to correct this? The Users will certainly not use it out of frame... ;(

[JohnMcLear]

Try put it in a normal frame container outside of your CMS and see if the problem exists. IE create