search

ether / etherpad-lite

Etherpad: A modern really-real-time collaborative document editor.
http://docs.etherpad.org/
Apache License 2.0
16.72k stars 2.85k forks source link

Bug when accenting letters #5623

Open JulienPalard opened 2 years ago

JulienPalard commented 2 years ago

Related to: https://github.com/ether/etherpad-lite/issues/5322

Describe the bug

When composing a letter with a diacritic the preceding space get dropped.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://hebdo.framapad.org/p/he92lzaewy-9x0j or any other etherpad-lite instance.
  2. Type the letter e (or any other letter).
  3. Type a space.
  4. Hit your compose key (It's easy to configure on Gnome in settings → keyboard → compose key. It can also be setup on Debian using dpkg --reconfigure keyboard-configuration)
  5. Type a e again.
  6. Type a quote '.

Expected behavior

The e and the ' should be composed to form a é without removing spaces around the pointer. But the preceding space is dropped, leading to eé instead of e é.

Screenshots

Capture vidéo du 2022-10-13 21-12-49.webm

Server (please complete the following information):

Desktop (please complete the following information):

Additional context

I use the compose key daily (I'm french on a QWERTY keyboard) on many many web-based things and I never reproduced this issue anywhere else.

toomsie commented 1 year ago

Is it possible to recreate this on the Mac. I am unable to reproduce that error.

haritak commented 1 year ago

On Endevearos (Arch linux) I can reproduce the error only on Firefox (115).

(using the greek letters with accent : έ ό ή ...)

Chrome, Konqueror and Opera look ok.

Update: On an old Mac: Safari and Firefox 115 (!) works ok! Seems only on Firefox and on Linux occurs...

SamTV12345 commented 1 month ago

Is this now fixed or do we need to do anything here?

haritak commented 1 month ago

Hello, thanks for taking the time to check this bug. Unfortunately the bug is still there.

For example, when I type:

άλλο ένα

I get on the screen

άλλοένα

The white space after άλλο is getting deleted when I hit the letter ε (having pressed the accent first). This is the order of keypresses: ΄ (accent) α λ λ ο (space) ΄ (accent) ε (this deletes the last space) ν α

I am on client: Firefox 130.0.1 (64-bit) EndeavourOS rolling linux 6.6.52-1-lts

and my server : etherpad git log : commit 1c459b3e418bbfbd337ce1e0a2e054f8bc502019 node v18.20.4 (tried 22.9.0 - had the same issue) Debian 12.7 kernel 6.1.0-25-amd64

I believe it has to do with firefox, because Konqueror, Google Chrome and Chromium do not exhibit this bug.

edit: Just to note I did a clean install of etherpad-lite