search

ether / etherpad-lite

Etherpad: A modern really-real-time collaborative document editor.
http://docs.etherpad.org/
Apache License 2.0
16.52k stars 2.84k forks source link

No Basic Auth #6247

Closed notaLonelyDay closed 6 months ago

notaLonelyDay commented 6 months ago

Describe the bug There's no basic auth popup. As I understand with this settings there should be basic auth popup, I've tried different browsers

All I see in browser is: Authentication Required And in logs:

etherpad  | [2024-03-19T22:23:03.095] [INFO] http - Failed authentication from IP x.x.x.x
etherpad  | [2024-03-19T22:23:04.973] [INFO] http - Failed authentication from IP x.x.x.x

My docker-compose:

  etherpad:
    container_name: etherpad
    image: etherpad/etherpad

    networks:
      etherpad:

    environment:
      DEFAULT_PAD_TEXT: ""
      ADMIN_PASSWORD: "***"
      USER_PASSWORD: "***"
      PAD_OPTIONS_USE_MONOSPACE_FONT: true
      PAD_OPTIONS_ALWAYS_SHOW_CHAT: true
      PAD_OPTIONS_CHAT_AND_USERS: true
      REQUIRE_AUTHENTICATION: true

    ports:
      - 9001:9001

Looks like because of this line: https://github.com/ether/etherpad-lite/blob/bd2198a70edc427353ec80c645063a6119fad5ca/src/node/hooks/express/webaccess.ts#L172

notaLonelyDay commented 6 months ago

Well with etherpad/etherpad:1.9.7 everything ok, it is bug

SamTV12345 commented 6 months ago

Hi @notaLonelyDay . It should be fixed on the develop branch