search

ether / etherpad-lite

Etherpad: A modern really-real-time collaborative document editor.
http://docs.etherpad.org/
Apache License 2.0
16.78k stars 2.86k forks source link

Building with submodule #6663

Open thmo opened 2 months ago

thmo commented 2 months ago

https://github.com/ether/etherpad-lite/blob/08f199178d2932cc0ec956aaeb3f62e8a535598a/Dockerfile#L116-L117

We are using etherpad-lite as a submodule, to build it in our CI with a given list of plugins. Being checked out as a submodule, there is no .git directory in the etherpad-lite directory, so these two lines will fail.

IIUC, this is used to allow running git inside the image to find out the version of etherpad - would it be possible to pass to skip this and e.g., set the version statically?

thmo commented 2 months ago

Hm, #6495 should have fixed this, but it doesn't seem to work for buildah build-using-dockerfile. Any idea?

SamTV12345 commented 2 months ago

Sorry no idea. I don't use buildah just docker itself.

thmo commented 2 months ago

See https://github.com/containers/buildah/issues/5742.