feat(desing): setup basic component

ether / etherpad-next

Rewrite of Etherpad using NextJS

Apache License 2.0

7 stars 3 forks source link

feat(desing): setup basic component #12

Closed AugustinMauroy closed 6 months ago

AugustinMauroy commented 6 months ago

Description

Introduce a few basic components that will be used to build more complex ones

Validation

It's should be cool. We didn't have any design system to follow so it's up to us.

Related Issues

No Related Issues

Check List

[X] I have formatted using npx turbo format
[X] I have checked the types using npx turbo type-check
[X] I have tested the build using npx turbo build

[!NOTE]\ To see how it's render open you edit on this branch and execute npm run storybook

SamTV12345 commented 6 months ago

I just had a look at the storybook. First of all the components really look great and fit into the theme of Etherpad. One thing I noticed is that button solid and gradient are the same.

AugustinMauroy commented 6 months ago

One thing I noticed is that button solid and gradient are the same.

I must have gotten confused when I coded them.

EDIT: the gradient is there, but potentially not strong enough if zoomed in to see it

SamTV12345 commented 6 months ago

One thing I noticed is that button solid and gradient are the same.

I must have gotten confused when I coded them.

EDIT: the gradient is there, but potentially not strong enough if zoomed in to see it

Oh yeah. I just noticed it. It is very very subtle.

AugustinMauroy commented 6 months ago

It is very very subtle.

you think it should be more pronounced ?

SamTV12345 commented 6 months ago

It is very very subtle.

you think it should be more pronounced ?

yes definetely. Otherwise a user won't be able to see the difference.