Feat(pwa): setup basic - Githubissues

ether / etherpad-next

Rewrite of Etherpad using NextJS

Apache License 2.0

7 stars 3 forks source link

Feat(pwa): setup basic #65

Closed AugustinMauroy closed 5 months ago

AugustinMauroy commented 5 months ago

Description

Adding basic of PWA for etherpad

Related Issues

No related issues

Check List

[X] I have formatted using npx turbo format
[X] I have checked the types using npx turbo type-check
[X] I have tested the build using npx turbo build
[X] I have covered the code with tests if necessary

SamTV12345 commented 5 months ago

We need to check with the settings. Can we somehow cache the object or do we really need to reread the settings over and over again?

AugustinMauroy commented 5 months ago

So the schema can validate if the settings are correctly entered.

Idk if he can check if valide. But it's allow to have ied auto completion/error.

We need to check with the settings. Can we somehow cache the object or do we really need to reread the settings over and over again?

I didn't get your message

SamTV12345 commented 5 months ago

So the schema can validate if the settings are correctly entered.

Idk if he can check if valide. But it's allow to have ied auto completion/error.

We need to check with the settings. Can we somehow cache the object or do we really need to reread the settings over and over again?

I didn't get your message

Yeah great. I meant that getMessage will always read the settings.json, parse it and the parsed settings are then added in the NextJS server component. Can we somehow cache the settings.json file in a JavaScript object that is then injected in the next app?

AugustinMauroy commented 5 months ago

Yeah great. I meant that getMessage will always read the settings.json, parse it and the parsed settings are then added in the NextJS server component. Can we somehow cache the settings.json file in a JavaScript object that is then injected in the next app?

Yeah. each time you call the function getSettings node will read file. But keep as mind Nextjs cache page/route so manifest.ts output is normally cache

SamTV12345 commented 5 months ago

Yeah great. I meant that getMessage will always read the settings.json, parse it and the parsed settings are then added in the NextJS server component. Can we somehow cache the settings.json file in a JavaScript object that is then injected in the next app?

Yeah. each time you call the function getSettings node will read file. But keep as mind Nextjs cache page/route so manifest.ts output is normally cache

Oh that's nice. Then there is nothing to complain about. Feel free to merge.