ether / pad

Etherpad Open-Source Repository
http://github.com/ether/pad
Other
1.03k stars 184 forks source link

"Horse blinkers" in default CSS #305

Closed AlainKnaff closed 10 years ago

AlainKnaff commented 12 years ago

By default, etherpad's CSS has the following in /usr/share/etherpad/etherpad/src/static/css/pad2_ejs.css after line 13:

padpage {

position: absolute; top: 0px; bottom: 8px; left: 50%; margin-left: -450px; width: 900px; }

This has the effect of making the display look "funny" on any window which is not 900 pixels wide: "horse blinkers" (unused bars left and right) on wide screens, and pad partially hidden without (!) scrollbars on small screens (such as the Nokia N900).

Just commenting out the entire paragraph makes the issue go away in both situations.

(copying the nano or micro pad2_ejs.css also solves the "horse blinkers" issue, but makes the sidebar disappear with no obvious way of making it re-appear)

JohnMcLear commented 12 years ago

Have you tested in all browsers?

AlainKnaff commented 12 years ago

tested in Firefox, Midori, Opera, Konqueror and Nokia N900

JohnMcLear commented 12 years ago

Afaik it is like that due to IE.

If you can put a page live I can test it w/ IETester

-----Original Message----- From: AlainKnaff [mailto:reply@reply.github.com] Sent: 12 November 2011 19:33 To: John McLear Subject: Re: [pad] "Horse blinkers" in default CSS (#305)

tested in Firefox, Midori, Opera, Konqueror and Nokia N900


Reply to this email directly or view it on GitHub: https://github.com/ether/pad/issues/305#issuecomment-2718966 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

AlainKnaff commented 12 years ago

You can visit https://etherpad.hitchhiker.org.lu/test

JohnMcLear commented 12 years ago

Non-full screen mode is broken.

Click Full screen in the top right corner.

-----Original Message----- From: AlainKnaff [mailto:reply@reply.github.com] Sent: 12 November 2011 19:44 To: John McLear Subject: Re: [pad] "Horse blinkers" in default CSS (#305)

You can visit https://etherpad.hitchhiker.org.lu/test


Reply to this email directly or view it on GitHub: https://github.com/ether/pad/issues/305#issuecomment-2719020 This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of the organisation from which this email originated. If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone. Please contact the sender if you believe you have received this email in error. This email was sent by School Email - Safe Webmail and Hosted Email for Schools;/p>

AlainKnaff commented 12 years ago

A ok. Yes, this fixes it. Both on wide screens and on the N900. Thanks.

But why is this not the default? Or can in be set up to be the default in /etc/etherpad/etherpad.local.properties ? If so, how?

sesam commented 12 years ago

There's no etherpad.local setting related to CSS/displaying for what I know. People more or less hack their template files and suffer whenever there is a central repo change to those files I guess... What are the pros with keeping a 900px width? To make documents look equal to all visitors whatever the screen size? Perhaps there is a way to keep 900px width and do the centering-stuff with javascript and only activate for large enough screens?

AlainKnaff commented 12 years ago

If users want width-independent display, can't they just press to start a new line? Or maybe we could introduce a special "pre-formatted" mode.

Well, in any case, this doesn't seem to be an issue in Etherpad Lite, which always uses the entire window or space available.

JohnMcLear commented 12 years ago

Yup..