search

ethercat-rs / ethercat

Rust wrapper for the IgH EtherCAT master
Apache License 2.0
58 stars 18 forks source link

Version of IgH ethercat code #16

Closed elias10101 closed 4 years ago

elias10101 commented 4 years ago

Nice work! Which version of the IgH Ethercat master code are you using for this wrapper?

birkenfeld commented 4 years ago

I was working with the default branch of the hg repository. Now I checked again and saw that apparently the IgH people are working exclusively on the stable-1.5 branch...

But I think it shouldn't matter too much; it looks the ioctl interface we use between userspace and kernelspace hasn't changed except for a shift in the ioctl numbers. You just need to generate the Rust bindings with the version you're also building the kernel module from.

flosse commented 4 years ago

Unfortunately there are differences... even between v1.5.2-sncn-7 and v1.5.2-sncn-11 (look at master/ioctl.h). See #17 (PR to update to v1.5.2-sncn-11).

birkenfeld commented 4 years ago

Ah damn, we aren't pulling the ioctl numbers from the header file... should we?

birkenfeld commented 4 years ago

In fact, it should be quite straightforward to autogenerate the ioctl! definitions from the #defines in ioctl.h.

birkenfeld commented 4 years ago

In any case, we should definitely point to the "canonical" branch we test with in the README.

flosse commented 4 years ago

Done with #22

flosse commented 4 years ago

... and 9f24c1b6bd44c2c8ee2a3c942876351febfb80f2