search

ethercat-rs / ethercat

Rust wrapper for the IgH EtherCAT master
Apache License 2.0
58 stars 18 forks source link

Replace deprecated ioctl crate with nix #2

Closed flosse closed 4 years ago

flosse commented 4 years ago

@birkenfeld Could you have a look at the used nix macros? At the moment I can't test the code :-\

birkenfeld commented 4 years ago

The ioctl-sys crate doesn't seem to be actually deprecated. Only ioctl is (but they are unaffiliated, strangely).

flosse commented 4 years ago

The ioctl-sys crate doesn't seem to be actually deprecated. Only ioctl is (but they are unaffiliated, strangely).

You're right, ioctl-sys is officially not deprecated but the latest release was Mar 17, 2017 and the latest commit was 20 Apr 2017 whereas the latest nix was released Feb 4, 2020 and is maintained by a large number of contributors.

birkenfeld commented 4 years ago

Sure, but it's small and stable, there's no outstanding issues in the repo, and I don't believe that you have to put out releases just to show activity. nix's scope is much, much broader so there's no surprise it needs (and gets) much more maintenance.

Still, maybe we'll need nix for other things in the future, so I'm fine with this (after comments are addressed). (Can't test with real HW at the moment either, though.)

flosse commented 4 years ago

Sure, but it's small and stable, there's no outstanding issues in the repo

You're right. So lets ignore my PR ;-) If there will be any problems in the future we can discuss again.