ethercreative / cart-notices

Automatically show notices based off cart details
Other
1 stars 1 forks source link

Support custom purchasables for 'Products in Cart' notice type #7

Open timeverts opened 4 years ago

timeverts commented 4 years ago

Having had a brief look at your code, it doesn't appear as though custom purchasables are supported when the notice type is 'Products in Cart'. I was wondering whether you might be willing to implement support for this as I could really use it for an upcoming project.

Some examples of custom purchasables are:

All custom purchasables extend the same craft\commerce\base\Purchasable class. The default Commerce product (which is actually a Variant) extends this class too, so it's really a custom purchasable itself.

If you want to see an example of supporting custom purchasables, take a look at the code and interface for the Promotions section in Commerce. Discounts and Sales can utilise both standard products and custom purchasables. It's should be a pretty straight forward implementation to support it since both a standard Commerce purchasable (i.e. product variant) and custom purchasable extend the same base functionality/class.

Thanks.

timeverts commented 4 years ago

Nine months later, is there any further update on this request?

timeverts commented 3 years ago

@Tam any update on the likely implementation of custom purchasable support? Could really have done with this feature for a current large project.

alexjcollins commented 3 years ago

@timeverts sorry for the embarrassingly long delay getting back to you on this request.

Honestly, it's something we'd really like to add but would probably depend on a client requiring the functionality (so we could pass the dev cost on). If the plugin was more popular or it was requested by a number of people, it may make it higher on the priority list.

If you wanted to make a PR with support for these I'd be happy to gift you a couple of free lifetime licenses