ethercreative / seo

SEO utilities including a unique field type, sitemap & redirect manager
MIT License
269 stars 96 forks source link

Duplicate Page never updates title in SEO Hook (FB & Twitter Meta info) #352

Closed gbaumbach closed 3 years ago

gbaumbach commented 3 years ago

Description

When you duplicate a page, the duplicate page inherits the original title and doesn't seem to update when you change the title or edit the SEO settings. I use the default {% hook 'seo' %} in my template.

Steps to reproduce

  1. Duplicate a page
  2. Edit that page title and check the meta settings for FB title and Twitter
  3. You can see the issue on this page's source code where I duplicated a previous page. The updates, but not the FB/Twitter Meta. <a rel="noreferrer nofollow" target="_blank" href="https://www.awarerecoverycare.com/addiction-epidemic/first-responders">https://www.awarerecoverycare.com/addiction-epidemic/first-responders</a></li> </ol> <h3>Additional info</h3> <ul> <li>Craft version: 3.6.13</li> <li>SEO version: Latest</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gbaumbach"><img src="https://avatars.githubusercontent.com/u/3330559?v=4" />gbaumbach</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <img width="869" alt="Screen Shot 2021-05-05 at 2 12 37 PM" src="https://user-images.githubusercontent.com/3330559/117189324-1304e480-adac-11eb-8947-d62ea7c4d871.png"> <p>You can see in the database table it still has the old title. Not sure how to update this besides updating the database itself.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alexjcollins"><img src="https://avatars.githubusercontent.com/u/12031196?v=4" />alexjcollins</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>@gbaumbach What is the field showing on your entry, out of interest?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gbaumbach"><img src="https://avatars.githubusercontent.com/u/3330559?v=4" />gbaumbach</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>First Responders as pictured here:</p> <img width="1472" alt="Screen Shot 2021-05-05 at 2 33 06 PM" src="https://user-images.githubusercontent.com/3330559/117191709-e1414d00-adae-11eb-9299-9e1f8b3029de.png"> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alexjcollins"><img src="https://avatars.githubusercontent.com/u/12031196?v=4" />alexjcollins</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>@gbaumbach Social meta isn't tokenised the same way as the primary meta values, so you'll need to tweak those manually. I notice the <code>Social</code> tab is missing from your screenshot, so you'll want to go to that field's settings and disable the hiding, so you can adjust those values.</p> <p><img src="https://user-images.githubusercontent.com/12031196/117243587-7126db80-ae2f-11eb-8ca1-036487d02fab.jpg" alt="Screenshot 2021-05-06 at 05 52 24" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/gbaumbach"><img src="https://avatars.githubusercontent.com/u/3330559?v=4" />gbaumbach</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Gotcha, that did the trick. Thank you!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alexjcollins"><img src="https://avatars.githubusercontent.com/u/12031196?v=4" />alexjcollins</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Cool – glad i could help!</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>