search

ethercreative / seo

SEO utilities including a unique field type, sitemap & redirect manager
MIT License
276 stars 95 forks source link

Craft 4: Plugin breaks GraphQL, getPublicVolumes() is removed #401

Closed niektenhoopen closed 2 years ago

niektenhoopen commented 2 years ago

Description

GraphQL does not work (at all) when the SEO plugin is enabled

It gives the following error:

{
  "errors": [
    {
      "message": "Calling unknown method: craft\\services\\Volumes::getPublicVolumes()"
    }
  ]
}

getPublicVolumes() is removed in https://github.com/craftcms/cms/commit/e93834d6b7b3ee2a5a7b9cc8b22e6249d04ed18b

Additional info

niektenhoopen commented 2 years ago

Already fixed in 4.0.1

niektenhoopen commented 2 years ago

@Tam Seems that Packagist does not recognise 4.0.1 (yet): https://packagist.org/packages/ether/seo

niektenhoopen commented 2 years ago

Also, I have issues with the current "fix" in 4.0.1:

Screenshot 2022-05-14 at 15 24 45
jesuismaxime commented 2 years ago

Any plan to merge that PR ☝️ that would be appreciated!

jesuismaxime commented 2 years ago

Any release date (on the plugin store - or available through composer) for 4.0.2 ?

niektenhoopen commented 2 years ago

@jesuismaxime As a work-around, you could theoretically require: "ether/seo": "v4.x-dev#9f56366"