Sitemap is being generated with leading spaces causing invalid XML

ethercreative / seo

SEO utilities including a unique field type, sitemap & redirect manager

MIT License

276 stars 95 forks source link

Sitemap is being generated with leading spaces causing invalid XML #420

Closed lopugit closed 2 years ago

lopugit commented 2 years ago

Description

sitemap.xml file is being generated with spaces at the start of the file making it an invalid XML document.

Visit https://sport.unimelb.edu.au/sitemap.xml to see, and view source

Steps to reproduce

Install SEO plugin
Generate sitemap

Additional info

Craft version: 3.7.46
SEO version: 3.7.4
PHP version: 8.0.18
Database driver & version:
Other Plugins:

lopugit commented 2 years ago

I've investigated this a bit and found that no matter what $response->content is set to in XmlController.php it always adds spaces at the start of the XML response. Is this an issue with \Craft::$app->getResponse(); ?

lopugit commented 2 years ago

Turned out to be some leading spaces added before a <?php tag in the routes file