ethercreative / seo

SEO utilities including a unique field type, sitemap & redirect manager
MIT License
267 stars 95 forks source link

Fix SEO field focus keywords on Craft 4. #444

Closed dyerc closed 1 year ago

dyerc commented 1 year ago

Fixes #431 and fixes #407 .

I thought I would investigate the issue with the focus keywords section on Craft version 4 and attempt to figure out what's happening. As far as I can tell, it's related to a change with the drafts / elements editor in Craft 4 and using the approach recommended in a similar thread, the focus keywords section appears to be working.

The override of window.Craft.ElementEditor.prototype.init in SeoField.js feels like a very poor solution, but I needed to ensure this code runs after the Craft ElementEditor is fully initialized.

After limited testing it appears to fix the focus keywords section, but if anybody wants to test this works, please have a try using the fork in your composer.json.

kevinmu17 commented 1 year ago

For testers: composer.json

  "repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/dyerc/seo"
    }
  ],
  "require": {
    "ether/seo": "dev-bugfix-keywords",
  }

run composer update

dyerc commented 1 year ago

what to put in the composer.json?

If you reference my repository in composer.json:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/dyerc/seo"
        }
    ]

Then run:

composer require ether/seo:dev-bugfix-keywords
kevinmu17 commented 1 year ago

This fixed the issue, thanks! hope ether will merge very soon!

dennis-vdw commented 1 year ago

Thanks @dyerc , this fixed the issue!