Spacing bug between page title and site name

pascalminator commented 1 year ago

Description

There is an annoying spacing bug between page title and site title, that appeared with the latest update of this plugin. It caused this problem on all the websites I updated so far. For example, before the update it was 'Page title - Site name' and now it is 'Page title- Site name'.

The spacing is properly defined (it is by default anyway) in the settings:

But ignored in the entries:

Steps to reproduce

Update the SEO plugin to latest version
Visit an entry with the SEO field used to set the page title and save
Open the saved page in front-end and look at the title with the newly missing spacing (Page title- Site title)

Additional info

Craft version: 4.4.8
SEO version: 4.1.1
PHP version: 8.2

pascalminator commented 1 year ago

So after investigation, this problem is caused by a Craft CMS update rather than an update from the SEO plugin. I updated Craft on a different site, without updating the SEO plugin, and the problem still occure.

Basically, the space after the page title is ignored / removed:

This is happening on absolutely all my websites using this SEO plugin, after the Craft update of 3 weeks ago.

alexjcollins commented 1 year ago

Thanks for the additional info; we'll take a look.

pascalminator commented 1 year ago

This issue is now also affecting the SEO plugin on Craft 3. I have a few websites on Craft 3 that were recently updated and are now getting this exact same problem: the space after the page title is ignored / removed.

The website in this screenshot was developed back in 2021 and never had this issue before.

Weirdly enough, it looks like it only affects the and not the Twitter and Facebook titles:</p> <p><img src="https://github.com/ethercreative/seo/assets/13754636/59a76085-2266-42ce-9360-651e1f1bdc26" alt="image" /></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

ethercreative / seo