ethercreative / tags

A tag manager for Craft 3
Other
21 stars 10 forks source link

Craft 4 support #26

Open acalvino4 opened 2 years ago

acalvino4 commented 2 years ago

Are there plans to keep this updated for Craft 4?

alexjcollins commented 2 years ago

@acalvino4 We'd certainly like to. We just need to determine the work involved so we can schedule accordingly.

I'll leave this open whilst we figure it out.

davidwebca commented 2 years ago

Craft core plans to remove Tags and Categories altogether eventually and give Entries UI capabilities that would enable them to be used and displayed as such. https://github.com/craftcms/cms/issues/820

That being said, it doesn't seem like they've moved much forward to adding that in 4.0 since the only core change they've made is to add draft functionalities to categories.

Our website uses tags pretty heavily so I'll try to see what would need to be done to add the compatibility for Craft 4.0 and I'll make a pull request.

mmikkel commented 2 years ago

The earliest Tags and Categories could be removed as core concepts is Craft 5.0, as it would be a major breaking change. In the interim, I'd love to see this plugin upgraded for Craft 4 compatibility.

wmdhosting commented 2 years ago

+1

theurbanu commented 2 years ago

+1

arifje commented 2 years ago

+1

jasonmorehead commented 2 years ago

+1

davidwebca commented 2 years ago

Just chiming in for all those +1s: I've been using my fork for a few weeks without any issue so far. So, for those who would need it right away while Ether reviews the pull request, you can pull my fork by changing your composer file like below. Don't forget the "repositories" part or it won't work.

{
  "require": {
    "ether/tags": "dev-master"
  },
  "repositories": [
    { "type": "git", "url": "https://github.com/davidwebca/craft-tags" }
  ]
}

Of course, this would be a temporary measure as I can't guarantee that my fork will stay up (I might delete my fork if and when the pull request gets approved). Make sure to update your file later if you do this!

swissmexxa commented 2 years ago

+1

viesrood commented 2 years ago

+1

CreateSean commented 2 years ago

+1

ricricucit commented 2 years ago

Curiosity: does @brandonkelly or anyone in pixel&tonic, personally have any strong opinion on this topic?

Makes me honestly wonder: what would be the technical reason behind this "missing feature"?

johndwells commented 2 years ago

+1

wmdhosting commented 2 years ago

can you review PR:. for craft 4

brandonkelly commented 2 years ago

Last week we announced that tags, categories, and global sets are going to be deprecated in Craft 4.4, and fully removed in Craft 5, in favor of entries (craftcms/cms#9781). And in 4.4 we will be adding a CLI tool that can be used to migrate existing tag groups, category groups, and global sets over to entries. We’ll also be making a couple improvements to Entries fields so they can replicate Categories and Tags fields’ UI (craftcms/cms#8522 + craftcms/cms#11379).

So in other words: this plugin won’t be needed anymore :)

rob-c-baker commented 2 years ago

This is great news. Not sure what the timeline is on Craft 5 but I'm guessing it's far enough away that some people may still need this.

wmdhosting commented 2 years ago

as much i understand in 4.4 will be avaible. in 5 just removed completly.. But yes as someone allready posted PR:: for 4.. not much work to make live

vebjorn commented 2 years ago

Last week we announced that tags, categories, and global sets are going to be deprecated in Craft 4.4, and fully removed in Craft 5, in favor of entries).

We need clarification on this then. Does deprecation mean that tags, categories and globals will be replaced with entries in 4.4? Or will deprecation here mean nothing else but a forewarning for Craft 5?

Q4 2023 is quite a while a head. A lot of us can not wait for over a year for something like this. But if 4.4 is a couple of days or weeks away, waiting might be something to consider

wmdhosting commented 2 years ago

And in 4.4 we will be adding a CLI tool that can be used to migrate existing tag groups, category groups, and global sets over to entries.

vebjorn commented 2 years ago

And in 4.4 we will be adding a CLI tool that can be used to migrate existing tag groups, category groups, and global sets over to entries.

That's an ambitious goal when the official roadmap for Craft says "Convert categories, tags, and global sets into entries" is planned for 5.x ..... there is a massive lack of info, and massive gap between what they say, and what is official info here.

brandonkelly commented 2 years ago

We need clarification on this then. Does deprecation mean that tags, categories and globals will be replaced with entries in 4.4? Or will deprecation here mean nothing else but a forewarning for Craft 5?

No, deprecated means those element types will still exist, but we no longer recommend you use them going forward. It doesn’t make sense to deprecate them before that because entries aren’t yet a viable alternative. They will be in 4.4 though.

Q4 2023 is quite a while a head. A lot of us can not wait for over a year for something like this. But if 4.4 is a couple of days or weeks away, waiting might be something to consider

No need to wait; nothing is changing for the time being. Categories, tags, and global sets are still recommended until 4.4. The CLI migration tool will help you move to entries when the time is right. (Could totally just be something you put off until you’re getting ready to upgrade to Craft 5 – if it ain’t broke don’t fix it.)

That's an ambitious goal when the official roadmap for Craft says "Convert categories, tags, and global sets into entries" is planned for 5.x ..... there is a massive lack of info, and massive gap between what they say, and what is official info here.

It’s a transition, but 5.0 will deliver the last nail in the coffin, so that’s why it’s marked as a 5.x feature.

vebjorn commented 2 years ago

That's an ambitious goal when the official roadmap for Craft says "Convert categories, tags, and global sets into entries" is planned for 5.x ..... there is a massive lack of info, and massive gap between what they say, and what is official info here.

It’s a transition, but 5.0 will deliver the last nail in the coffin, so that’s why it’s marked as a 5.x feature.

Thanks for clarifying @brandonkelly ! This ought to be something outlined somehow in the roadmap though, or am I weird? :)

brandonkelly commented 2 years ago

Yeah fair.

“Relate ancestors” setting for Entries/Categories fields was already present for 4.x.

Just added “Create <element type>” button for relational fields and Category/tag/global set → entry conversion tool, which were missing.

theAdhocracy commented 2 years ago

@brandonkelly Are you also looking at porting across the Tags UI? Specifically, the ability to quickly search, select, and create "tags" (I guess that should now just read "entries") all from a single input element? And then double-click to open up an editor where further fields can be filled in?

We're currently stuck on Craft 3 as we need the speed of being able to quickly add new tags that this provides. We've also found that the pop-out list of Categories often takes a long time to load, whereas Tag autocomplete seems to be nearly instantaneous. As a result, we've been slowly migrating almost all Categories to Tags, but I'm now wary of that strategy if we're going to lose the UI in the near future?

brandonkelly commented 2 years ago

@theAdhocracy Yeah inline entry creation will be possible from Entries fields, similar to how Tags fields work.

smockensturm commented 1 year ago

I wouldn't mind a state of the state here. I don't see anything (as of Craft 4.5.9) nearly replicating the sweet UI of searching, adding and creating tags on the fly that this plugin affords.

I dig this plugin for that alone. I don't want something similar or something functionally the same. I want this.

So what's going on? Wil this plugin be Craft 4 compatible? Will @brandonkelly replicate a sweet tagging UI exactly?

theAdhocracy commented 1 year ago

@smockensturm Just to be clear, the Tags plugin is available for Craft 4 and it works exactly like Craft 3. We're running it at the moment with no issues. You just need to keep your Tags as, well, Tags, rather than go through the entrification process with them.

As for Craft 5, time will tell. I wasn't able to make dot.all and the video of the keynote is not clear on how the UI functions, but it looks like there will be a variety of options available. I'm in the same boat though; we need the same UI experience. So fingers crossed 🤞

smockensturm commented 1 year ago

Just to be clear, the Tags plugin is available for Craft 4 and it works exactly like Craft 3.

Yeah, I suppose. Thanks for the rundown.

Screen Shot 2023-11-17 at 10 21 27 AM
jonnykates commented 1 month ago

@smockensturm In your previous screenshot, you've got two 'delete' options. We're encountering this problem too whilst using the Tags plugin on Craft 4 (without having entrified our tags). Did you work out a solution for this? I guess one of the 'delete' options is Craft's native delete whereas the other is the Tag plugin handler (which opens a modal giving the user the change to replace etc.).

smockensturm commented 1 month ago

@jonnykates No. This plugin apparently is a bust. Because 'entrification' is the way forward.

https://craftcms.com/docs/5.x/reference/element-types/tags.html

But we stiil don't know what @brandonkelly plans for the sweet inline tags UI.

https://craftcms.com/docs/5.x/reference/element-types/tags.html

https://github.com/ethercreative/tags/issues/26#issuecomment-1280858790