search

ethercrow / opentelemetry-haskell

The OpenTelemetry Haskell Client https://opentelemetry.io
Other
65 stars 6 forks source link

eventlogs to opentelemetry converter #23

Open yaitskov opened 4 years ago

yaitskov commented 4 years ago

grps is not supported on 8.10

yaitskov commented 4 years ago

As of now I run out of ideas how to skip proto module for 8.10

ethercrow commented 4 years ago

Hopefully they will fix it at some point.

yaitskov commented 4 years ago

I hope so, but what about stack and cabal? How many build system should be in a Haskell project to change a light bulb? Could nix be rescue?

yaitskov commented 4 years ago

proto-lens ticket for support 8.10 is closed, nonetheless build is still failing. Hackage version is not changed. I tried to pull proto-lens dependency directly from a github branch, but I don't see any difference in stack behavior.

I doubt that the snipped is working for packages already in Hackage. How stack figures out that a git repo is for proto-lens? Tries to prefetch? Imh it is error prone approach cause I could make type in subdirs. 

- git: https://github.com/google/proto-lens
  commit 12312312312
yaitskov commented 4 years ago

I complete first version of OpenTelemetry translator and noticed mismatching between internal and OT structures: our event is (name, value, timestamp) but OT (name, attributes map <k,v>, ts) so there is no obvious way for mapping. OT name could be fixed and name goes into attribute key or vice versa.

yaitskov commented 4 years ago

@ethercrow , proto-lens issue is resolved. Now build failing due git proto submodule is not fetched by CI. I guess I need tweak following lines, but I don't see travis like file in the project.

git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress \
    --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* \
    +refs/pull/23/merge:refs/remotes/pull/23/merge