search

etherdelta / etherdelta.github.io

https://etherdelta.com
555 stars 689 forks source link

API for trading an existing order? #172

Open rnamdev opened 6 years ago

rnamdev commented 6 years ago

Hi, API for orders and placing buy and sell order seems to work okay. I am curious if there is an API for trading (buying) an existing sell order and vice versa.

Thanks & Regards Rahul

zackcoburn commented 6 years ago

For that, the smart contract itself is the API. A trade is a smart contract transaction.

On Mon, Oct 9, 2017 at 9:57 AM rnamdev notifications@github.com wrote:

Hi, API for orders and placing buy and sell order seems to work okay. I am curious if there is an API for trading (buying) an existing sell order and vice versa.

Thanks & Regards Rahul

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/etherdelta/etherdelta.github.io/issues/172, or mute the thread https://github.com/notifications/unsubscribe-auth/APEqPfzkrCaZmzMHaZfvBJWw92NjoV4jks5sqiYrgaJpZM4PyhvM .

-- Zack Coburn

NOTICE: This e-mail transmission (and/or the attachments accompanying it) may contain confidential information belonging to the sender which is protected by law. The information is intended only for the use of the intended recipient. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this information is strictly prohibited. Any unauthorized interception of this transmission is illegal. If you have received this transmission in error, please promptly notify the sender by reply e-mail, and then destroy all copies of the transmission.

Pearlsome commented 6 years ago

Can you explain your answer, maybe with small example? I need same function and cann't understand what you mean.

zackcoburn commented 6 years ago

I'll have sample code for this in the future. Not ready yet though.

Zack Coburn

NOTICE: This e-mail transmission (and/or the attachments accompanying it) may contain confidential information belonging to the sender which is protected by law. The information is intended only for the use of the intended recipient. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this information is strictly prohibited. Any unauthorized interception of this transmission is illegal. If you have received this transmission in error, please promptly notify the sender by reply e-mail, and then destroy all copies of the transmission.

On Thu, Oct 12, 2017 at 2:24 PM, Pearlsome notifications@github.com wrote:

Can you explain your answer, maybe with small example? I need same function and cann't understand what you mean.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/etherdelta/etherdelta.github.io/issues/172#issuecomment-336224116, or mute the thread https://github.com/notifications/unsubscribe-auth/APEqPZueGv459YWsS9rirIhUM-1q4oh1ks5srllGgaJpZM4PyhvM .

Pearlsome commented 6 years ago

So right now there is no way to sell/buy to exsisting orders?

zackcoburn commented 6 years ago

No, there is, it just has to be done through the Ethereum API, and I haven't provided a code sample for it yet. But it's possible to do on your own if you're familiar with sending smart contract transactions.

Zack Coburn

NOTICE: This e-mail transmission (and/or the attachments accompanying it) may contain confidential information belonging to the sender which is protected by law. The information is intended only for the use of the intended recipient. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this information is strictly prohibited. Any unauthorized interception of this transmission is illegal. If you have received this transmission in error, please promptly notify the sender by reply e-mail, and then destroy all copies of the transmission.

On Thu, Oct 12, 2017 at 2:26 PM, Pearlsome notifications@github.com wrote:

So right now there is no way to sell/buy to exsisting orders?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/etherdelta/etherdelta.github.io/issues/172#issuecomment-336224740, or mute the thread https://github.com/notifications/unsubscribe-auth/APEqPapGHFoLptqaafov9BRuoOqkJtMnks5srlnOgaJpZM4PyhvM .

osapishchuk commented 6 years ago

Hi @zackcoburn, any updates on this topic? do you have that code example you mentioned in this ticket? Thanks in advance, Oleg