search

ethereum-attestation-service / eas-sdk

Ethereum Attestation Service - TypeScript/JavaScript SDK
MIT License
83 stars 38 forks source link

Timestamp docs not updates on doc #100

Closed agroernesto closed 2 weeks ago

agroernesto commented 2 weeks ago

I notice that the documentation on the readme regarding timestamps is not updated.

sending a PR to fix this

agroernesto commented 2 weeks ago

101

lbeder commented 2 weeks ago

Hey @agroernesto, You can use EAS to timestamp any data. Not only attestations.

agroernesto commented 2 weeks ago

Got it, but is not clear in the docs, maybe add the two examples will help, or be more explicit about it. Because if you try to use the example of the uid with the method on the readme will fail. At least for me, I was doing some tinkering with the sdk and got stucked with that for a while.

Just trying to help Best

lbeder commented 2 weeks ago

Yeah, adding the UID examples, in addition to the existing generic example, is a good idea. If you could update your PR, I'd be more than happy merging it

ernestosperanza commented 2 weeks ago

Glad to do it, let me know if is ok, this way

102