search

ethereum-attestation-service / eas-sdk

Ethereum Attestation Service - TypeScript/JavaScript SDK
MIT License
83 stars 39 forks source link

Fix decoding w/ arrays #53

Closed MrSaints closed 11 months ago

MrSaints commented 11 months ago

Component can be null, resulting in an empty array being set by default, but we are not appropriately handling it:

TypeError: Cannot read properties of undefined (reading 'name')

The newly added test captures this case.

lbeder commented 11 months ago

Thanks for your contribution @MrSaints! Could you just make sure to the PR passes linter checks (https://github.com/ethereum-attestation-service/eas-sdk/actions/runs/5909071300/job/16031960766?pr=53)?

MrSaints commented 11 months ago

Updated @lbeder :) Thanks.