ethereum-attestation-service / eas-sdk

Ethereum Attestation Service - TypeScript/JavaScript SDK
MIT License
95 stars 47 forks source link

Import of OFFCHAIN_ATTESTATION_VERSION and Offchain seems not to be working atm #77

Closed michael-spengler closed 8 months ago

michael-spengler commented 9 months ago

Can be tested by trying

import { OFFCHAIN_ATTESTATION_VERSION, Offchain  } from "@ethereum-attestation-service/eas-sdk"

as recommended here: https://github.com/ethereum-attestation-service/eas-sdk#verify-an-offchain-attestation

monique-baumann commented 8 months ago

@slavik0329: once this is fixed, I can further improve https://deno.land/x/ethereum_attestation_service

If you want the deno module in your org, let me know. I can transfer it if you wish.

Btw. Deno is cool. You might give it a chance.

lbeder commented 8 months ago

https://github.com/ethereum-attestation-service/eas-sdk#verify-an-offchain-attestation

The README.md was updated here: 8177f39dd1b38814954242813975ab2487b58cdd. Please use OffChainAttestationVersion instead.

What issue are you having with importing Offchain?

michael-spengler commented 8 months ago

https://github.com/ethereum-attestation-service/eas-sdk#verify-an-offchain-attestation

The README.md was updated here: 8177f39. Please use OffChainAttestationVersion instead.

Thank You. Will try it.

What issue are you having with importing Offchain? ... does not export ... called Offchain. Will look into it later again. Maybe due to strict typescript checks...

monique-baumann commented 8 months ago

@lbeder: have you also planned to introduce:

Interchain Attestations

This would be amazing imo - especially in times when the numbers of layer 2s grow like weed. :)

michael-spengler commented 8 months ago

@lbeder: have you also planned to introduce:

Interchain Attestations

This would be amazing imo - especially in times when the numbers of layer 2s grow like weed. :)

Yeah. The EAS could facilitate reliable cross chain communications... This would boost many cool projects like Interchain Investment DAOs, Freedom Enterprises etc.

monique-baumann commented 8 months ago

Attestations could be like: Contract on Chain X has the following state at block.timestamp ...

monique-baumann commented 8 months ago

OffChainAttestationVersion

https://github.com/ethereum-attestation-service/eas-sdk#verify-an-offchain-attestation

The README.md was updated here: 8177f39. Please use OffChainAttestationVersion instead.

@lbeder The commit you have mentioned is about something else imo. I confirm the error persists with "OffChainAttestationVersion" atm. Error message: The requested module 'npm:@ethereum-attestation-service/eas-sdk' does not provide an export named 'OffChainAttestationVersion' What issue are you having with importing Offchain? same with "Offchain": The requested module 'npm:@ethereum-attestation-service/eas-sdk' does not provide an export named 'Offchain'

Everything else in the sdk seems to work perfectly fine with deno ... :+1:

lbeder commented 8 months ago

OffChainAttestationVersion

https://github.com/ethereum-attestation-service/eas-sdk#verify-an-offchain-attestation

The README.md was updated here: 8177f39. Please use OffChainAttestationVersion instead.

@lbeder The commit you have mentioned is about something else imo. I confirm the error persists with "OffChainAttestationVersion" atm. Error message: The requested module 'npm:@ethereum-attestation-service/eas-sdk' does not provide an export named 'OffChainAttestationVersion'

What issue are you having with importing Offchain? same with "Offchain": The requested module 'npm:@ethereum-attestation-service/eas-sdk' does not provide an export named 'Offchain'

Everything else in the sdk seems to work perfectly fine with deno ... 👍

I've published a new version that fixes the lowercase typo (it should be OffchainAttestationVersion instead of OffChainAttestationVersion). Please check it out.

I'm not familiar with the Deno module, but I'd suggest to continue the discussion about in our telegram group.

monique-baumann commented 8 months ago

thanks - currently the only error which still exists imo is: Screenshot from 2024-01-08 21-49-45

monique-baumann commented 8 months ago

Offchain

thanks - currently the only error which still exists imo is: Screenshot from 2024-01-08 21-49-45

while https://github.com/monique-baumann/deno-eas/blob/main/src/deno-eas.ts#L1

We might also look into it on Wednesday. If we find a solution we'll share it. Thank you for the EAS ...

lbeder commented 8 months ago

This doesn't seem to be an issue with the SDK itself, but rather how it's being (re)built by an external framework