ethereum-attestation-service / eas-sdk

Ethereum Attestation Service - TypeScript/JavaScript SDK
MIT License
95 stars 47 forks source link

Version2 not defined #79

Closed monique-baumann closed 8 months ago

monique-baumann commented 8 months ago

Screenshot from 2024-01-16 15-29-07

https://github.com/ethereum-attestation-service/eas-sdk/blob/master/README.md?plain=1#L300

monique-baumann commented 8 months ago

additionally you might check and simplify bigint vs. number typing. This seems not too consistent yet - e.g. in the context of https://github.com/ethereum-attestation-service/eas-sdk/blob/master/README.md?plain=1#L317

lbeder commented 8 months ago

I'm not sure where are these types coming from (we don't export types this way), but Version2 is indeed defined https://github.com/ethereum-attestation-service/eas-sdk/blob/bff294c361176116f1580d2b4558a1f58fc61eef/src/offchain/offchain.ts#L26.

Please ensure that if you integrate/build the SDK externally - you are rebuilding it with every update.

lbeder commented 8 months ago

We can't maintain external builds/framework ourselves

lbeder commented 8 months ago

additionally you might check and simplify bigint vs. number typing. This seems not too consistent yet - e.g. in the context of https://github.com/ethereum-attestation-service/eas-sdk/blob/master/README.md?plain=1#L317

chainId is should be BigInt everywhere. It appears that your own managed types aren't up-to-date.

lbeder commented 8 months ago

@monique-baumann please try deleting dist and running pnpm build or checkout a clean version.