search

ethereum-attestation-service / eas-sdk

Ethereum Attestation Service - TypeScript/JavaScript SDK
MIT License
83 stars 38 forks source link

Offchain attestation that requires refUID #91

Closed thongxuan closed 2 months ago

thongxuan commented 2 months ago

Hi, I'm in a situation where I have to create off-chain attestation that references an on-chain attestation.

Also, my schema resolver logic requires validating the attestation provided in refUID.

Due to the fix in this PR: https://github.com/ethereum-attestation-service/eas-sdk/pull/54, which set the refUID to be zero bytes 32 all the time, my resolver logic fails.

https://github.com/ethereum-attestation-service/eas-sdk/blob/ef088c138a1d72d7a673cb73d89c9c3b431be2ec/src/offchain/offchain.ts#L217-L220

My question: could we allow simulating resolver with refUID: params.refUID || ZERO_BYTES32 ?

lbeder commented 2 months ago

Great suggestion @thongxuan! We will finish working on some important fixes and release this fix with the new version asap.

thongxuan commented 2 months ago

Great to hear that! Thank you!!