search

ethereum-lists / 4bytes

List of 4byte identifiers for EVM smart contract functions
MIT License
470 stars 103 forks source link

Extracting task from Mist internals #1

Closed evertonfraga closed 6 years ago

evertonfraga commented 6 years ago

In Mist we download the signatures from https://4byte.directory. Here's our contribution :)

ligi commented 6 years ago

Thanks so much! :+1: :1st_place_medal: :tada: - might change the scripts to be kotlin-gradle at some point but this is a wonderful start - was not even aware of this API - will come very handy for the signer.

evertonfraga commented 6 years ago

Nice, glad to help!

ligi commented 6 years ago

@evertonfraga FYI: https://ethereum.stackexchange.com/questions/40297/should-uis-handle-4byte-signature-collisions - this is also the main reason I was going for https://github.com/ethereum-lists/4bytes/pull/2

From what I see this implementation would even override the first entry. So someone could forge a collision - upload to the 4byte directory and then his method would be the one shown to the user.

evertonfraga commented 6 years ago

No problem! in our original code, it handles collisions in the data structure, but we don't make anything special at the UI level.

I liked your implementation, it prevents loading a huge object into scope. 👍