ethereum-lists / 4bytes

List of 4byte identifiers for EVM smart contract functions
MIT License
470 stars 103 forks source link

Can't submit function signature "mint(uint256 nonce, bytes32 challenge_digest)" to the directory #28

Closed smarx closed 6 years ago

smarx commented 6 years ago

I thought I'd help out by submitting signatures some hashes in https://github.com/ethereum-lists/4bytes/issues/25#issuecomment-396250160.

I tried via https://www.4byte.directory/submit/ to submit the signature mint(uint256 nonce, bytes32 challenge_digest), but it seems to have been misinterpreted as mint(int256,uint256,bytes32). My guess without reading code is that the "int" in "mint" was misinterpreted as a parameter.

ligi commented 6 years ago

thanks for the hint - cc @pipermerriam

smarx commented 6 years ago

FYI, perhaps the same problem with mint(address _to, uint256 _amount). (Not 100% sure how this one was interpreted because I just got a 500.) This is also in the "top 20" list.

ligi commented 6 years ago

yea also getting 500 now - might be more instances of this: https://github.com/pipermerriam/ethereum-function-signature-registry/issues/30 Maybe I make a separate backend soon to decouple from this python stuff ;-)

smarx commented 6 years ago

Ah, I couldn't find the repo for the website. Should I open an issue over there so we can close this one?

ligi commented 6 years ago

that would be great!

smarx commented 6 years ago

Opened https://github.com/pipermerriam/ethereum-function-signature-registry/issues/31.

pipermerriam commented 6 years ago

Should be resolved.