ethereum-lists / 4bytes

List of 4byte identifiers for EVM smart contract functions
MIT License
468 stars 103 forks source link

signatures: a bit of vetting #43

Closed holiman closed 2 years ago

holiman commented 2 years ago

This PR changes the order of a few of the signature default-choices, so the 'best' is the first option.

This one is obviously phony:

sig `a6f9dae1`
 - func18397752363851325826(address,address,uint256)
 - changeOwner(address)

This does not look right to me, with the double ((:

sig `ac04f243`
 - stake((uint256))
 - getRoyaltyShares(uint256)

And a few more like that.

In total, here are the conflicts:

sig a6f9dae1

sig 08bfa40a

sig 169272ef

sig ac04f243

sig 50b7e942

sig a08f1e8e

sig abbf4b17

sig d71787e9

sig 3ad17f6d

sig 57172196

sig e6dd9a8d

sig a5cd3fd0

sig 53a1add4

sig d10f18dd

sig d40dc870

sig 2626ab08

sig d9fd7341

sig b5674c68

sig 918d407d

sig 22061379

sig dd62ed3e

sig a8de09b3

sig 09779838

sig 04d742dc

sig 463a1ffe

sig 91dd36c6

sig d05f5acb

sig 67e43e43

sig 74a37efc

sig 6772f279

sig e7f02cba

sig fa461e33

sig 5d37a8dd

sig 2dd34f0f

sig 5f575529

sig 65bbb26a

sig 927fef2e

sig 81821fed

sig 41973cd9

sig 033b9bec

sig 462fc765

sig eaf5815a

sig 8c429c74

sig a65dd261

sig 24d97a4a

sig bf20d9dc

sig c7d595fa

sig 3bb2dead

sig 134cc3f9

holiman commented 2 years ago

Wonder how you found them all in the first place - I find it hard to vet with this amount of signatures and gave up vetting a while ago tbh. But thanks for doing that! Appreciated.

https://github.com/holiman/abidbbuilder/

go run abidbbuilder.go -i /home/user/workspace/4bytes/signatures -o ./sigs.json

I removed this line to get a bit less output: https://github.com/holiman/abidbbuilder/blob/master/abidbbuilder.go#L153 , so basically only printed the collisions