search

ethereum-mining / ethminer

Ethereum miner with OpenCL, CUDA and stratum support
GNU General Public License v3.0
5.97k stars 2.28k forks source link

Suggestion: use Coverity Scan / Clang-Tidy / other tools to find code problems #1045

Closed unquietwiki closed 5 years ago

unquietwiki commented 6 years ago

Given the list of issues here; and the sensitivity of the work being done (financial & computer security); it might make sense to have some code linting and static analysis as part of the build and fix process.

XhmikosR commented 6 years ago

https://github.com/ethereum-mining/ethminer/tree/coverity

chfast commented 6 years ago

I'd like to have clang-tidy, but never had it integrated in CI...

XhmikosR commented 6 years ago

And I also haven't got a reply from coverity on how to remove the current project and enable Travis for it...

unquietwiki commented 6 years ago

@chfast I found this. Might help? https://www.reddit.com/r/cpp/comments/7obg9p/how_do_you_use_clangtidy/

chfast commented 6 years ago

Yes, thanks. However I prefer it to be a part of CMake directly. I will try to add it.

AndreaLanfranchi commented 5 years ago

@chfast ... still relevant ?

chfast commented 5 years ago

Basics done in #1715 and #1721. @XhmikosR was working on coverity.

XhmikosR commented 5 years ago

The thing is...

  1. the current coverity version does not seem to work with the latest MSVC
  2. I couldn't make Travis work
  3. There's like zero support from coverity

So, I'd say we should just leave the branch there in case someone else wants to take a stab at it later.