search

ethereum-mining / ethminer

Ethereum miner with OpenCL, CUDA and stratum support
GNU General Public License v3.0
5.97k stars 2.28k forks source link

MinerAux.h uses stol() to set unsigned integers instead of stoul() #140

Closed YanBellavance closed 6 years ago

YanBellavance commented 7 years ago

not a deal breaker but we should be using stoul instead of stol since the return value of stol is assigned to an unsigned always:

m_numStreams = stol(argv[++i]);

was it done on purpose?

EoD commented 7 years ago

@YanBellavance unlikely, it came with commit 56bb6941ace2fd01d3a70a56b4773537337ba3e7 .

Would you create a pull request about your suggested change?

chfast commented 7 years ago

Patches welcome.

DeadManWalkingTO commented 6 years ago

Any news here?

YanBellavance commented 6 years ago

Sorry i been so busy....you would loke me to update all the fixes I made in a pull request? Im just so busy right now....gotta make ends meet for my project

Le mar. 27 févr. 2018 5:48 PM, DeadManWalking notifications@github.com a écrit :

Any news here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ethereum-mining/ethminer/issues/140#issuecomment-369055075, or mute the thread https://github.com/notifications/unsubscribe-auth/Ab9Rr7dc5F21CH76F2hoBUQEzOdP2CXuks5tZIYzgaJpZM4OR2fL .