search

ethereum-mining / ethminer

Ethereum miner with OpenCL, CUDA and stratum support
GNU General Public License v3.0
5.96k stars 2.28k forks source link

Wrong code reintroduced. #1586

Closed AndreaLanfranchi closed 5 years ago

AndreaLanfranchi commented 5 years ago

Why do we still have this ?

https://github.com/ethereum-mining/ethminer/blob/master/libpoolprotocols/stratum/EthStratumClient.cpp#L463

It was amended by this. https://github.com/ethereum-mining/ethminer/commit/79c25a98d915d94f750e9f6f263814f28930b3ff

Why I see wrong code popping back ?

Are we sure we do sync always ?

@chfast @jean-m-cyr @StefanOberhumer

AndreaLanfranchi commented 5 years ago

Never mind. Sorry. It's me browsing an old release.

Sorry.